Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Verify variable change calls on every move in TRACKED_FULL_ASSERT #1260

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Christopher-Chianelli
Copy link
Contributor

@Christopher-Chianelli Christopher-Chianelli commented Dec 6, 2024

Additional changes:

  • Assigned/Unassigned values are now tracked.

Future changes:

  • Ensuring there are no changes outside the affected range.

@triceo
Copy link
Contributor

triceo commented Jan 8, 2025

I've been thinking. VariableListenerSupport already tracks these events - see Notification, its children and where they are created. Why not hook this code in there instead? Seems to me that we are duplicating this information, making the assert mode even slower where maybe we can reuse what we've already built anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants