fix: ensure the sort manner is applied to the default CH config #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zepfred
changed the title
zepfred
changed the title
triceo
reviewed
Dec 6, 2024
...i/timefold/solver/core/impl/constructionheuristic/DefaultConstructionHeuristicPhaseTest.java
Outdated
Show resolved
Hide resolved
triceo
approved these changes
Dec 6, 2024
...mefold/solver/core/impl/testdata/domain/difficultyweight/TestdataDifficultyWeightEntity.java
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request corrects a bug that occurs when an entity selector configuration is created without using the sorting settings, particularly when the related entity has a difficulty weight factory defined
@PlanningEntity(difficultyWeightFactoryClass....The bug only affects solver configurations that do not define a phase list, as the solver sets the entity selector configuration before inner operations update the heuristic policy configuration. The issue does not affect the value selector config because no config is created by default (
DefaultSolverFactory#buildPhaseList).