Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: run OpenRewrite recipe tests in parallel #1252

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

triceo
Copy link
Contributor

@triceo triceo commented Dec 4, 2024

No description provided.

@triceo
Copy link
Contributor Author

triceo commented Dec 4, 2024

@timtebeek For whatever reason, I am no longer seeing the failures I saw before. I will have the entire CI run, that tests on all platforms, maybe something shows up.

Copy link

sonarqubecloud bot commented Dec 4, 2024

@triceo
Copy link
Contributor Author

triceo commented Dec 4, 2024

OK, still no sign of any exception. Ran it a hundred times locally, ran the entire CI three times - I guess I'll attribute the exceptions I saw to cosmic bit flips. If it ever happens again, I'll write it down and report directly to OpenRewrite. Thanks @timtebeek!

@triceo triceo requested a review from zepfred December 4, 2024 10:08
@triceo triceo added this to the 1.17.0 milestone Dec 4, 2024
@triceo triceo self-assigned this Dec 4, 2024
@timtebeek
Copy link
Contributor

Looks like a great improvement indeed; locally I see the 160 tests in AsConstraintRecipeTest go down from ~35 seconds to just 10. Now I wonder if we can do the same. 😅

@triceo triceo merged commit 05539ad into TimefoldAI:main Dec 4, 2024
28 checks passed
@triceo triceo deleted the parallel branch December 4, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants