-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: unify the handling of list variable shadows #1228
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
triceo
commented
Nov 28, 2024
core/src/main/java/ai/timefold/solver/core/impl/domain/variable/ListVariableStateSupply.java
Show resolved
Hide resolved
triceo
commented
Nov 28, 2024
core/src/main/java/ai/timefold/solver/core/impl/domain/variable/ListVariableStateSupply.java
Show resolved
Hide resolved
@Christopher-Chianelli Since you're going to be using this later, would you mind reviewing? |
Quality Gate passedIssues Measures |
Christopher-Chianelli
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; possible performance improvements:
- Merge NextElementVariableProcessor and PrevElementVariableProcessor into a single, final class, and add a private final int field that +1 for NextElementProcessor, and -1 for PrevElementProcessor.
- Do not call
getInverseSingleton
andgetIndex
ingetLocationInList
, since they both do a map lookup on the same element.
core/src/main/java/ai/timefold/solver/core/impl/domain/variable/ListVariableState.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All shadow variables related to a list variable are now handled in one unified loop, as opposed to each having its own variable listener.
This should technically be a performance improvement, but in fact a barely significant regression of 3 % was measured in some cases. (Other cases show minor improvements.)
This change also makes internalized previous/next shadows possible, and that in turn will help with the revamp of shadow variables that is currently in development.
Therefore we introduce this change even though it may bring a small performance regression.