Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Address Sonar issues post-nullness (Part 3) #1198

Merged
merged 1 commit into from
Nov 12, 2024
Merged

chore: Address Sonar issues post-nullness (Part 3) #1198

merged 1 commit into from
Nov 12, 2024

Conversation

triceo
Copy link
Contributor

@triceo triceo commented Nov 12, 2024

No description provided.

@triceo triceo requested a review from zepfred November 12, 2024 13:15
zepfred
zepfred approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@zepfred zepfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@triceo triceo merged commit 91a12cb into TimefoldAI:main Nov 12, 2024
26 checks passed
@triceo triceo deleted the sonar3 branch November 12, 2024 14:08
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
66.1% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zepfred zepfred zepfred approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@triceo @zepfred