New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Address Sonar issues post-nullness (Part 2) #1197

Merged

triceo merged 7 commits into TimefoldAI:main from triceo:sonar2

Nov 12, 2024

Contributor

triceo commented Nov 12, 2024

No description provided.


          More Sonar

dcbab34

triceo temporarily deployed to internal

November 12, 2024 08:46

— with

GitHub Actions Inactive


          Even more Sonar

triceo temporarily deployed to internal

November 12, 2024 09:01

— with

GitHub Actions Inactive


          Formatting

30cc05b

triceo temporarily deployed to internal

November 12, 2024 09:03

— with

GitHub Actions Inactive


          More!

a32735c

triceo closed this

triceo temporarily deployed to internal

November 12, 2024 09:56

— with

GitHub Actions Inactive

triceo reopened this

triceo temporarily deployed to internal

November 12, 2024 09:57

— with

GitHub Actions Inactive


          Even more!

385d8a0

triceo temporarily deployed to internal

November 12, 2024 10:08

— with

GitHub Actions Inactive


          Formatting

4e08586

triceo temporarily deployed to internal

November 12, 2024 10:13

— with

GitHub Actions Inactive

triceo changed the title ~~More Sonar~~ chore: Address Sonar issues post-nullness (Part 2)

triceo marked this pull request as ready for review

November 12, 2024 10:14

triceo requested a review from zepfred

November 12, 2024 10:14

zepfred reviewed

View reviewed changes

...old/solver/core/impl/heuristic/selector/move/generic/list/ListChangeMoveSelectorFactory.java Outdated Show resolved Hide resolved

zepfred reviewed

View reviewed changes

...old/solver/core/impl/heuristic/selector/move/generic/list/ListChangeMoveSelectorFactory.java Outdated Show resolved Hide resolved

zepfred reviewed

View reviewed changes

...rc/main/java/ai/timefold/solver/core/impl/heuristic/selector/value/ValueSelectorFactory.java Outdated Show resolved Hide resolved

zepfred reviewed

View reviewed changes

core/src/main/java/ai/timefold/solver/core/impl/score/director/easy/EasyScoreDirector.java Outdated Show resolved Hide resolved

zepfred reviewed

View reviewed changes

core/src/main/java/ai/timefold/solver/core/impl/score/stream/common/InnerConstraintFactory.java Outdated Show resolved Hide resolved

zepfred reviewed

View reviewed changes

core/src/main/java/ai/timefold/solver/core/impl/solver/termination/TerminationFactory.java Show resolved Hide resolved

zepfred reviewed

View reviewed changes

...java/ai/timefold/solver/jackson/api/domain/solution/ConstraintWeightOverridesSerializer.java Outdated Show resolved Hide resolved

zepfred reviewed

View reviewed changes

...java/ai/timefold/solver/jackson/api/domain/solution/ConstraintWeightOverridesSerializer.java Outdated Show resolved Hide resolved

zepfred reviewed

View reviewed changes

.../main/java/ai/timefold/solver/spring/boot/autoconfigure/TimefoldSolverAutoConfiguration.java Outdated Show resolved Hide resolved

zepfred approved these changes

View reviewed changes

Contributor

zepfred left a comment

LGTM!


          Review

a345ba5

triceo temporarily deployed to internal

November 12, 2024 11:08

— with

GitHub Actions Inactive

triceo merged commit c1694e7 into TimefoldAI:main

25 of 26 checks passed

triceo deleted the sonar2 branch

November 12, 2024 11:23

sonarqubecloud bot commented Nov 12, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
76.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet