feat: add new termination config based on the best solution improvement #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zepfred
force-pushed
the
new-stuck-criterion
branch
from
9d20981 to
7e8466e
Compare
triceo
reviewed
Nov 12, 2024
triceo
reviewed
Nov 12, 2024
.../java/ai/timefold/solver/core/impl/solver/termination/UnimprovedBestSolutionTermination.java
Outdated
Show resolved
Hide resolved
triceo
reviewed
Nov 12, 2024
.../java/ai/timefold/solver/core/impl/solver/termination/UnimprovedBestSolutionTermination.java
Outdated
Show resolved
Hide resolved
triceo
reviewed
Nov 12, 2024
.../java/ai/timefold/solver/core/impl/solver/termination/UnimprovedBestSolutionTermination.java
Outdated
Show resolved
Hide resolved
triceo
reviewed
Nov 12, 2024
.../java/ai/timefold/solver/core/impl/solver/termination/UnimprovedBestSolutionTermination.java
Outdated
Show resolved
Hide resolved
triceo
reviewed
Nov 12, 2024
There was a problem hiding this comment.
This is not a typical curve for medium-soft scores.
When a medium score improves, typically the best score becomes worse than it was before.
Also, we should clearly explain that this image applies to situations where the score has multiple levels.
There was a problem hiding this comment.
You're thinking about score levels while I am considering the solution score. If the medium score improves, the solution score improves wherever the soft levels are. The current implementation of the solver utilizes lexicographic dominance.
triceo
reviewed
Nov 12, 2024
docs/src/modules/ROOT/images/optimization-algorithms/overview/terminationGrowthCurve.png
Outdated
Show resolved
Hide resolved
triceo
reviewed
Nov 12, 2024
docs/src/modules/ROOT/pages/optimization-algorithms/overview.adoc
Outdated
Show resolved
Hide resolved
triceo
reviewed
Nov 12, 2024
docs/src/modules/ROOT/pages/optimization-algorithms/overview.adoc
Outdated
Show resolved
Hide resolved
triceo
reviewed
Nov 12, 2024
docs/src/modules/ROOT/pages/optimization-algorithms/overview.adoc
Outdated
Show resolved
Hide resolved
triceo
reviewed
Nov 12, 2024
docs/src/modules/ROOT/pages/optimization-algorithms/overview.adoc
Outdated
Show resolved
Hide resolved
triceo
reviewed
Nov 12, 2024
docs/src/modules/ROOT/pages/optimization-algorithms/overview.adoc
Outdated
Show resolved
Hide resolved
|
I left first initial comments. I think we need:
In the current state, I worry people wouldn't understand. (If I didn't already understand, I think the current explanation would leave me confused.) |
zepfred
force-pushed
the
new-stuck-criterion
branch
from
7c5ec1c to
e11de80
Compare
zepfred
force-pushed
the
new-stuck-criterion
branch
from
5792183 to
54310a2
Compare
zepfred
force-pushed
the
new-stuck-criterion
branch
from
0f1b33c to
e8fb143
Compare
zepfred
force-pushed
the
new-stuck-criterion
branch
from
e8fb143 to
caae946
Compare
zepfred
force-pushed
the
new-stuck-criterion
branch
from
11fb134 to
d38fa3d
Compare
|
zepfred
force-pushed
the
new-stuck-criterion
branch
from
390f71e to
a104eb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new termination condition that activates when the solver cannot improve the best solution within a specified time frame. This time frame is determined by the speed of move evaluations, the last time the solver successfully improved the solution, and the duration without any improvements.