Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable score analysis without justifications #1185

Merged
merged 11 commits into from
Nov 7, 2024

Conversation

triceo
Copy link
Contributor

@triceo triceo commented Nov 7, 2024

Introduces an option to disable constraint match justifications,
while still keeping constraint matching enabled.
In some cases, the dataset is so large that justifications are pointless,
and impractical to send over the wire as well.
In this case, score analysis only provides constraint match count, and not the full match analysis.

@triceo triceo added the enhancement New feature or request label Nov 7, 2024
@triceo triceo added this to the 1.16.0 milestone Nov 7, 2024
@triceo triceo requested a review from zepfred November 7, 2024 08:27
@triceo triceo self-assigned this Nov 7, 2024
Copy link
Contributor

@zepfred zepfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. Will we need to provide the Python counterpart?

@triceo
Copy link
Contributor Author

triceo commented Nov 7, 2024

Wrt. Python - I checked and I don't think so.

@zepfred zepfred self-requested a review November 7, 2024 12:53
Copy link

sonarqubecloud bot commented Nov 7, 2024

@triceo triceo merged commit 06d2c82 into TimefoldAI:main Nov 7, 2024
25 of 27 checks passed
@triceo triceo deleted the matchcount branch November 7, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants