fix: Use inserted range when retracting range in toConnectedRanges
#1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
triceo
requested changes
Aug 27, 2024
Comment on lines
+24
to
+25
| final var mapped = mapper.apply(a, b); | ||
| final var saved = calculator.insert(mapped); |
There was a problem hiding this comment.
final shouldn't be necessary here. The variable is effectively final without it too.
There was a problem hiding this comment.
I prefer final to explicitly mark it as final/as something that shouldn't be changed.
Comment on lines
+26
to
+27
| final var mapped = mapper.apply(a, b, c, d); | ||
| final var saved = calculator.insert(mapped); |
Comment on lines
+24
to
+25
| final var mapped = mapper.apply(a, b, c); | ||
| final var saved = calculator.insert(mapped); |
Comment on lines
+24
to
+25
| final var mapped = mapper.apply(a); | ||
| final var saved = calculator.insert(mapped); |
...fold/solver/core/impl/score/stream/collector/connected_ranges/ConnectedRangeSolvingTest.java
Outdated
Show resolved
Hide resolved
The `ConnectedRangesCalculator` incorrectly assumes the range for each value is constant. The fix is to save the range on insert, and then pass the saved range on retract. The other calculators do not have this problem, because either: - Their input should be immutable (ex: number) - They used a map in their internal data structure that saved the original value
Christopher-Chianelli
force-pushed
the
fix/953
branch
from
d1053aa to
9167c5c
Compare
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
triceo
approved these changes
Aug 27, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ConnectedRangesCalculatorincorrectly assumes the range for each value is constant. The fix is to save the range on insert, and then pass the saved range on retract. The other calculators do not have this problem, because either:Fixes #953