-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add nullness annotations on public API (WIP) #1009
feat: add nullness annotations on public API (WIP) #1009
Conversation
Thanks for the PR, @greyhairredbear! |
FYI @greyhairredbear:
|
d087bed
to
0a5f96f
Compare
Quality Gate failedFailed conditions |
2e6c957
to
1a49816
Compare
further: add missing annotations to BiConstraintStream
… TriConstraintCollector
- mostly non-null annotations for score classes utilizing BigDecimal
seems to have gone wrong during refactor->change signature
f029c90
to
d0f9a4a
Compare
Sorry, I thought this was waiting for #1149 to be completed - but I just saw some tests there are still failing because Java 21 is not supported. I guess it's ok to merge this, so I'll undraft it. Please don't hesitate to contact me if there are any issues related to this, I'd be glad to help and don't want to block anybody. I'll open a new PR with the remaining tasks and reference it from here once I start working on the remaining changes. |
Thank you, @greyhairredbear! I will merge this later today. |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Opening this draft PR to see CI results for javadoc & collect early feedback
Open items (remaining open items are to be delivered with #1160)
Skipped (for now):
PiggybackShadowVariable.shadowVariableName
) - not sure if this would be valuable. IDE complains "Attribute value must be constant" when trying to assignnull
here. If there is value in this because the solver internally uses these attributes, I'd be ok with adding these too.