Skip to content

Commit

Permalink
chore: Remove GraalVM for Java 17 from Quarkus test, fix some warnings
Browse files Browse the repository at this point in the history
- Per quarkusio/quarkus#44877, GraalVM for
  Java 21 is recommended even for Java 17 projects, since GraalVM
  for Java 17 has weird issues with Quarkus

- Use quarkus.native.enabled since quarkus.package.type is deprecated

- Use org.graalvm.sdk:nativeimage instead of
  org.graalvm.sdk:graalvm-sdk per the recommendation in the logs
  • Loading branch information
Christopher-Chianelli authored and triceo committed Dec 2, 2024
1 parent 2cf8b28 commit aaa88f2
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 4 deletions.
7 changes: 7 additions & 0 deletions .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,13 @@ jobs:
os: [ ubuntu-latest ] # Windows doesn't work, Mac is not a deploy OS.
module: ["spring-integration", "quarkus-integration"]
java-version: [ 17, 21, 23 ] # LTS + latest.
exclude:
# Quarkus 3.17.2 has weird issues with Java 17 GraalVM,
# with Java 21+ GraalVM being recommended even for
# Java 17 projects.
# https://github.com/quarkusio/quarkus/issues/44877
- module: "quarkus-integration"
java-version: 17
timeout-minutes: 120
steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion quarkus-integration/quarkus/devui-integration-test/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@
</plugins>
</build>
<properties>
<quarkus.package.type>native</quarkus.package.type>
<quarkus.native.enabled>true</quarkus.native.enabled>
</properties>
</profile>
</profiles>
Expand Down
2 changes: 1 addition & 1 deletion quarkus-integration/quarkus/integration-test/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
</plugins>
</build>
<properties>
<quarkus.package.type>native</quarkus.package.type>
<quarkus.native.enabled>true</quarkus.native.enabled>
</properties>
</profile>
</profiles>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
</plugins>
</build>
<properties>
<quarkus.package.type>native</quarkus.package.type>
<quarkus.native.enabled>true</quarkus.native.enabled>
</properties>
</profile>
</profiles>
Expand Down
2 changes: 1 addition & 1 deletion quarkus-integration/quarkus/runtime/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
</dependency>
<dependency>
<groupId>org.graalvm.sdk</groupId>
<artifactId>graal-sdk</artifactId>
<artifactId>nativeimage</artifactId>
</dependency>
</dependencies>
<build>
Expand Down

0 comments on commit aaa88f2

Please sign in to comment.