chore: resolve open todos

TimefoldAI · Nov 6, 2024 · 8f97503 · 8f97503
1 parent 3e21eed
commit 8f97503
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 7 deletions.
diff --git a/...i/timefold/solver/core/config/heuristic/selector/common/nearby/NearbySelectionConfig.java b/...i/timefold/solver/core/config/heuristic/selector/common/nearby/NearbySelectionConfig.java
@@ -246,7 +246,6 @@ public void setBetaDistributionBeta(@Nullable Double betaDistributionBeta) {
     // Builder methods
     // ************************************************************************
 
-    // TODO clarify if @NonNull is ok for both params
     public void validateNearby(@NonNull SelectionCacheType resolvedCacheType, @NonNull SelectionOrder resolvedSelectionOrder) {
         long originSelectorCount = Stream.of(originEntitySelectorConfig, originSubListSelectorConfig, originValueSelectorConfig)
                 .filter(Objects::nonNull)

diff --git a/...n/java/ai/timefold/solver/core/config/heuristic/selector/entity/EntitySelectorConfig.java b/...n/java/ai/timefold/solver/core/config/heuristic/selector/entity/EntitySelectorConfig.java
@@ -329,9 +329,8 @@ public String toString() {
         return getClass().getSimpleName() + "(" + entityClass + ")";
     }
 
-    // TODO: entityDescriptor @NonNull?
     public static <Solution_> boolean hasSorter(@NonNull EntitySorterManner entitySorterManner,
-            EntityDescriptor<Solution_> entityDescriptor) {
+            @NonNull EntityDescriptor<Solution_> entityDescriptor) {
         switch (entitySorterManner) {
             case NONE:
                 return false;

diff --git a/.../main/java/ai/timefold/solver/core/config/heuristic/selector/move/MoveSelectorConfig.java b/.../main/java/ai/timefold/solver/core/config/heuristic/selector/move/MoveSelectorConfig.java
@@ -238,7 +238,6 @@ public void setFixedProbabilityWeight(@Nullable Double fixedProbabilityWeight) {
      * except for {@link UnionMoveSelectorConfig} and {@link CartesianProductMoveSelectorConfig}.
      *
      */
-    // TODO: list elements @NonNull?
     public void extractLeafMoveSelectorConfigsIntoList(@NonNull List<@NonNull MoveSelectorConfig> leafMoveSelectorConfigList) {
         leafMoveSelectorConfigList.add(this);
     }

diff --git a/...ain/java/ai/timefold/solver/core/config/heuristic/selector/value/ValueSelectorConfig.java b/...ain/java/ai/timefold/solver/core/config/heuristic/selector/value/ValueSelectorConfig.java
@@ -341,9 +341,8 @@ public String toString() {
         return getClass().getSimpleName() + "(" + variableName + ")";
     }
 
-    // TODO: variableDescriptor @NonNull?
     public static <Solution_> boolean hasSorter(@NonNull ValueSorterManner valueSorterManner,
-            GenuineVariableDescriptor<Solution_> variableDescriptor) {
+            @NonNull GenuineVariableDescriptor<Solution_> variableDescriptor) {
         switch (valueSorterManner) {
             case NONE:
                 return false;

diff --git a/test/src/main/java/ai/timefold/solver/test/api/score/stream/SingleConstraintAssertion.java b/test/src/main/java/ai/timefold/solver/test/api/score/stream/SingleConstraintAssertion.java
@@ -18,7 +18,6 @@ public interface SingleConstraintAssertion {
      * @param message description of the scenario being asserted
      * @throws AssertionError when the expected penalty is not observed
      */
-    // TODO: justifications @NonNull correct
     @NonNull
     SingleConstraintAssertion justifiesWith(@Nullable String message,
             @NonNull ConstraintJustification @NonNull... justifications);