Skip to content

Commit

Permalink
TileDB-SOMA-R: define CXX20FLAGS in ~/.R/Makevars
Browse files Browse the repository at this point in the history
TileDB-SOMA recently migrated from C++17 to C++20,
so I updated CXX17FLAGS to CXX20FLAGS.

However, I observed that no matter if I exported
CXXFLAGS in the build step, the install step, or
both, the deprecation warnings were not suppressed.

I was only able to suppress the deprecation warnings
by following the example upstream and defining
CXX20FLAGS in ~/.R/Makevars. Only then were the flags
added to the call to g++.

https://github.com/single-cell-data/TileDB-SOMA/blob/cd1e4876100d32f0f6a494bb7ba8e07868b1885e/.github/workflows/r-ci.yml#L102
  • Loading branch information
jdblischak committed Nov 26, 2024
1 parent 1b241cc commit 4de0e59
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions .github/workflows/linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -487,13 +487,12 @@ jobs:
install.packages(binary_tarball, repos = NULL)
- name: Dependencies
run: cd apis/r && tools/r-ci.sh install_all
- name: Remove deprecation warnings
run: mkdir ~/.R && echo "CXX20FLAGS=-Wno-deprecated-declarations -Wno-deprecated" > ~/.R/Makevars
- name: Build
run: |
export CXX17FLAGS="-Wno-deprecated-declarations -Wno-deprecated"
cd apis/r && R CMD build --no-manual --no-build-vignettes .
run: cd apis/r && R CMD build --no-manual --no-build-vignettes .
- name: Install
run:
cd apis/r && R CMD INSTALL --install-tests --build tiledbsoma_*.tar.gz
run: cd apis/r && R CMD INSTALL --install-tests --build tiledbsoma_*.tar.gz
- name: Upload R binary tarball as artifact
uses: actions/upload-artifact@v4
with:
Expand Down

0 comments on commit 4de0e59

Please sign in to comment.