Fix/Generalize test added in #2083 #2116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kounelisagis
force-pushed
the
agis/test-fix
branch
from
ac79327 to
41b653e
Compare
kounelisagis
changed the title
kounelisagis
force-pushed
the
agis/test-fix
branch
from
41b653e to
cabc3e8
Compare
|
The only CI failure was for macOS with Python 3.9: I suspect this was a spurious failure, and regardless appears unrelated to the changes this PR makes to |
jdblischak
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
This test failure is blocking the feedstock release of 0.33.0 in conda-forge/tiledb-py-feedstock#249
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2083, the
"S"dtype is used in the new test to verify that dropping a fixed-size attribute and adding it back as variable-size now works as expected. However, this caused the issue described here: TileDB-Inc/conda-forge-nightly-controller#151 (comment).Instead of testing with a specific value, we should test with both
"S"and"U"dtypes but assert the fill value of the attribute before writing any data to it. This approach makes the test more generic for all types.The same problem also appears in #2114, so it would be better to apply this fix before merging that PR.
cc @jdblischak, @dudoslav
[sc-59851]