Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor _write_array out of Cython #2115

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

kounelisagis
Copy link
Member

No description provided.

@kounelisagis kounelisagis force-pushed the agis/move_write_array_to_python branch 2 times, most recently from 213490e to 3ba2e49 Compare December 5, 2024 03:33
@kounelisagis kounelisagis force-pushed the agis/move_write_array_to_python branch from 3ba2e49 to a1046ed Compare December 5, 2024 03:37
@kounelisagis kounelisagis marked this pull request as ready for review December 5, 2024 03:38
Copy link
Collaborator

@nguyenv nguyenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Just some minor suggestions.

tiledb/cc/query.cc Show resolved Hide resolved
tiledb/cc/query.cc Show resolved Hide resolved
tiledb/cc/query.cc Show resolved Hide resolved
tiledb/array.py Outdated Show resolved Hide resolved
tiledb/array.py Outdated Show resolved Hide resolved
tiledb/array.py Outdated Show resolved Hide resolved
tiledb/array.py Outdated Show resolved Hide resolved
tiledb/array.py Outdated Show resolved Hide resolved
tiledb/array.py Outdated Show resolved Hide resolved
@kounelisagis kounelisagis requested a review from nguyenv December 6, 2024 08:36
@kounelisagis kounelisagis force-pushed the agis/move_write_array_to_python branch from 865ecba to e302f4c Compare December 6, 2024 08:41
@kounelisagis kounelisagis force-pushed the agis/move_write_array_to_python branch from 52e81cb to 18f5f50 Compare December 6, 2024 13:03
@kounelisagis kounelisagis merged commit 76e62f6 into pybind11-full Dec 6, 2024
27 checks passed
@kounelisagis kounelisagis deleted the agis/move_write_array_to_python branch December 6, 2024 18:34
kounelisagis added a commit that referenced this pull request Dec 9, 2024
kounelisagis added a commit that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants