Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 1933 agis/sc 43316/add wrapping for ls recursive #1964

Merged

Conversation

kounelisagis
Copy link
Member

tiledb/cc\vfs.cc(56): error C2039: 'VFSExperimental': is not a member of 'tiledb'
C:\include\tiledb\subarray_experimental.h(41): note: see declaration of 'tiledb'
tiledb/cc\[vfs.cc](http://vfs.cc/)(56): error C3083: 'VFSExperimental': the symbol to the left of a '::' must be a type
tiledb/cc\vfs.cc(56): error C2039: 'ls_recursive': is not a member of 'tiledb'
C:\include\tiledb\subarray_experimental.h(41): note: see declaration of 'tiledb'
tiledb/cc\[vfs.cc](http://vfs.cc/)(56): error C3861: 'ls_recursive': identifier not found
tiledb/cc\vfs.cc(65): error C2039: 'VFSExperimental': is not a member of 'tiledb'
C:\include\tiledb\subarray_experimental.h(41): note: see declaration of 'tiledb'
tiledb/cc\[vfs.cc](http://vfs.cc/)(65): error C3083: 'VFSExperimental': the symbol to the left of a '::' must be a type
tiledb/cc\vfs.cc(65): error C2039: 'ls_recursive': is not a member of 'tiledb'
C:\include\tiledb\subarray_experimental.h(41): note: see declaration of 'tiledb'
tiledb/cc\[vfs.cc](http://vfs.cc/)(65): error C3861: 'ls_recursive': identifier not found
  • Removes ls_recursive from history

ls_recursive functionality will be added in a patch release with a version guard.

@kounelisagis kounelisagis requested a review from dudoslav May 10, 2024 09:50
@kounelisagis kounelisagis merged commit 75e32f9 into dev May 10, 2024
33 of 34 checks passed
@kounelisagis kounelisagis deleted the revert-1933-agis/sc-43316/add-wrapping-for-ls-recursive branch May 10, 2024 10:05
@kounelisagis kounelisagis restored the revert-1933-agis/sc-43316/add-wrapping-for-ls-recursive branch May 15, 2024 13:59
kounelisagis added a commit that referenced this pull request May 15, 2024
kounelisagis added a commit that referenced this pull request May 15, 2024
@kounelisagis kounelisagis deleted the revert-1933-agis/sc-43316/add-wrapping-for-ls-recursive branch May 23, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants