Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove modular building option #1938

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

kounelisagis
Copy link
Member

Removes the --modular option when building TileDB-Py.

@kounelisagis kounelisagis requested review from ihnorton and nguyenv April 1, 2024 11:33
Copy link

This pull request has been linked to Shortcut Story #43445: Remove deprecated cython IF usage.

@nguyenv
Copy link
Collaborator

nguyenv commented Apr 1, 2024

I understand the IF keyword is deprecated in Cython now, but does that mean we need to get rid of the TILEDBPY_MODULAR option? I also have never toggled TILEDBPY_MODULAR so don't have any context for how that macro is used.

@kounelisagis
Copy link
Member Author

I understand the IF keyword is deprecated in Cython now, but does that mean we need to get rid of the TILEDBPY_MODULAR option? I also have never toggled TILEDBPY_MODULAR so don't have any context for how that macro is used.

After discussed with @ihnorton, we will remove the whole TILEDBPY_MODULAR option.

@ihnorton
Copy link
Member

ihnorton commented Apr 1, 2024

@nguyenv this is untested/unmaintained, and was always kind of brittle; not necessary now with pybind work.

Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kounelisagis kounelisagis merged commit f252bcc into dev Apr 1, 2024
28 checks passed
@kounelisagis kounelisagis deleted the agis/sc-43445/remove-deprecated-cython-if-usage branch April 1, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants