Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update type signature for VFS::readinto #1937

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Update type signature for VFS::readinto #1937

merged 1 commit into from
Mar 29, 2024

Conversation

kounelisagis
Copy link
Member

@kounelisagis kounelisagis commented Mar 29, 2024 •
edited
Loading

@kounelisagis kounelisagis requested a review from sgillies March 29, 2024 12:30
@shortcut-integration Shortcut Integration
Copy link

This pull request has been linked to Shortcut Story #42838: Update type signature for VFS::readinto.

@kounelisagis kounelisagis requested a review from ihnorton March 29, 2024 12:38
sgillies
sgillies reviewed Mar 29, 2024
View reviewed changes
tiledb/vfs.py Outdated Show resolved Hide resolved
sgillies
sgillies requested changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@sgillies sgillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest that we not introduce deprecated usage.

@kounelisagis kounelisagis force-pushed the agis/sc-42838/update-type-signature-for-vfs-readinto branch from dcb4616 to d3f3df6 Compare March 29, 2024 15:35
@kounelisagis kounelisagis force-pushed the agis/sc-42838/update-type-signature-for-vfs-readinto branch from d3f3df6 to d88a236 Compare March 29, 2024 15:53
sgillies
sgillies approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@sgillies sgillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

ihnorton
ihnorton approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kounelisagis and @sgillies!

@kounelisagis kounelisagis merged commit 9621995 into dev Mar 29, 2024
28 checks passed
@kounelisagis kounelisagis deleted the agis/sc-42838/update-type-signature-for-vfs-readinto branch March 29, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihnorton ihnorton ihnorton approved these changes

@sgillies sgillies sgillies approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kounelisagis @sgillies @ihnorton