Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update daily test builds to use single source of truth for libtiledb target versions #1910

Conversation

kounelisagis
Copy link
Member

@kounelisagis kounelisagis commented Mar 4, 2024

Currently, we have two different daily ("nightly") build jobs run on a schedule. These jobs have different specifications for where they get the libtiledb version:

  1. daily-test-build.yml specifies a version matrix
  2. daily-test-build-numpy.yml uses the version in setup.py

We would like to change this to use github actions workflow_call from a single list of versions.

See the following examples in libtiledb repo:

Daily workflow manually run by me: https://github.com/TileDB-Inc/TileDB-Py/actions/runs/8144967109

Copy link

@kounelisagis kounelisagis force-pushed the agis/sc-42336/update-daily-test-builds-to-use-single-source-of-truth-for-libtiledb-target-versions branch 2 times, most recently from 3a2a62e to 684d1ff Compare March 4, 2024 18:09
@kounelisagis kounelisagis force-pushed the agis/sc-42336/update-daily-test-builds-to-use-single-source-of-truth-for-libtiledb-target-versions branch from 684d1ff to 4c27e7c Compare March 4, 2024 18:09
Copy link
Collaborator

@dudoslav dudoslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, did you have a chance to test this on your local fork for example?

@kounelisagis
Copy link
Member Author

@dudoslav I run it manually, as I wrote in the description of the PR.

@kounelisagis kounelisagis merged commit 3ad8ed0 into dev Mar 6, 2024
69 of 74 checks passed
@kounelisagis kounelisagis deleted the agis/sc-42336/update-daily-test-builds-to-use-single-source-of-truth-for-libtiledb-target-versions branch March 6, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants