Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TidierData compat fix #112

Merged
merged 1 commit into from
Aug 9, 2024
Merged

TidierData compat fix #112

merged 1 commit into from
Aug 9, 2024

Conversation

drizk1
Copy link
Member

@drizk1 drizk1 commented Aug 4, 2024

fixes issue outlined here so that TidierData can be updated while using most recent TidierPlots version

@drizk1
Copy link
Member Author

drizk1 commented Aug 9, 2024

Hey @rdboyes just wanted to lightly ping u on your thoughts for this PR just changing the tidierdata compat line?

I think the reason the it's not building the docs has to do with permissions - seems to be a similar situation to the inherit aes PR which was merged.

But let me know if I need to dig further into the docs build issue.

@rdboyes
Copy link
Member

rdboyes commented Aug 9, 2024

Sorry! I've been busy and haven't been checking this - I think we can merge it

@rdboyes rdboyes merged commit cc5a4fb into TidierOrg:main Aug 9, 2024
3 of 4 checks passed
@drizk1
Copy link
Member Author

drizk1 commented Aug 9, 2024

No worries at all! Hopefully my ping didn't break ur flow. Ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants