Use DropWaker SubmissionQueue::cancel_op #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of always using the Box implementation, meaning we always allocate, we now require the caller to pass resources that implement DropWaker. This means we can avoid the allocation for various types that implement DropWaker already. The downside is that in the case where we got no more events the allocation is made upfront (for certain types) and then dropped, without actually being in a waker.
A more action-y name for the trait, which matches the usual Rust trait naming convention.
This is useful for the types that don't implement DropWake themselves and thus have to use a Box. That Box allocation can now be delayed until it's actually needed, which might not be needed if we expect no further events for the submission.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of always using the Box implementation, meaning we always
allocate, we now require the caller to pass resources that implement
DropWaker.
This means we can avoid the allocation for various types that implement
DropWaker already.