Feature: Display number of employees per Function #7955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jniles
force-pushed
the
feat-show-number-workers-per-function
branch
from
31757f6 to
2f62192
Compare
jniles
force-pushed
the
refactor-payroll-management
branch
from
cd1a9d8 to
a10945c
Compare
Converts the server side code to async/await, removes duplicate FunctionService.
Adds a column to the "function registry" to show the number of employees with that function assigned.
Removes an unused, untranslated chart-modal.html. No idea where it came from.
Implements the same style of batch creates used on the account modal for creating functions.
Removes technical debt by removing duplicate code.
jniles
force-pushed
the
feat-show-number-workers-per-function
branch
from
2f62192 to
c3da21d
Compare
Fixes lint errors in employee modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not ready for a merge yet. Give me some time to refine it.
This PR refines
Functionmodule for better maintainability. It removes the duplicateFunctionServiceand migrates the server route toasync/await. It also implements the feature requested in #7797 for displaying the number of employees associated with each function. Here is what that looks like:Additionally, to facilitate the creation of multiple functions at a time, it implements the account-style "batch create" function. Currently, while this works, it does not refresh the background items, which is a poor user experience. I'll rework this before final merge.
TODO:
Closes #7797