Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add poetry, ruff and pyright config #1130

Open
wants to merge 5 commits into
base: 2.18-Beta
Choose a base branch
from

Conversation

DinhHuy2010
Copy link

Related Issue/Addition to code

  • Fixes #
  • Addition to code.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Proposed Changes

  • change to poetry
  • add ruff and pyright
  • add pyproject.toml
  • Add scripts

Why is this change needed?

  • Poetry make managing dependencies eaiser (More info)
  • Ruff for linting and formatting (way faster than the black formatting) (More info)
  • Pyright for type checking (for autocompletion and check code) (More info)

Additional Info

  • TODO List:
  • Completely remove requirements.txt
  • Update the documentation, the linux installer script, etc.

Checklist:

  • My code follows the style guidelines of this project and I have read CONTRIBUTING.md
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Screenshots

Original Updated
** original screenshot ** ** updated screenshot **

@DinhHuy2010 DinhHuy2010 changed the title 2.18 beta ruff Add poetry, ruff and pyright config Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant