-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implemented multithreading using the multiprocessing module #1116
base: 2.18-Beta
Are you sure you want to change the base?
Conversation
converted YOUTUBE variable to a list of 2 builds rather than a single 1
replace instances of auth.YOUTUBE with auth.YOUTUBE[0]
in the get_comments function, multithreading has been added
changed an instance of auth.YOUTUBE to auth.YOUTUBE[0]
replaced instances of auth.YOUTUBE to auth.YOUTUBE[0]
it is about the second element
I forgot to add this before
What documentation is my checklist referring to? |
this is currently a basic setup for multi-threading the scanning of comments using only 2 CPU cores |
@ThioJoe I think multithreading is done, what do you think? |
found a bug that causes it to freeze, I will reopen when its fixed and tested for other bugs |
i also found out i forgot to implement shared memory which might be the cause |
i implemented shared memory but now there is way too much ram usage and a unrelated bug i am currentlly fixing |
i fixed the memory leak but there is still the issue of freezing on certain videos after 1 thread finishes |
I am reopening this since it is mostly fixed |
I found a variety of more videos with the freezing issue |
I found out that it is for any comment with more than 100 replies |
@ThioJoe this is ready now |
Can you explain why there's 1 reference to |
It is only for multi threading, I tried using it like it was before but errors were caused so unfortunately there needs to be 2 of them, maybe if other things get multithreaded it will have other uses |
Related Issue/Addition to code
Old-Multi-Threading-Attempt
Type of change
Proposed Changes
Why is this change needed?
It's needed because it speeds up scanning alot
Additional Info
Checklist: