Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use internal pre aliases and expose as pre #240

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use internal pre aliases and expose as pre #240

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c35903
use internal pre aliases and expose as pre
ThibaultJanBeyer Oct 26, 2024
f772170
Merge branch 'main' into change-pre-aliases
ThibaultJanBeyer Oct 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 28 additions & 21 deletions DragSelect/src/methods/subscriberAliases.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,13 +87,21 @@ export type DSPublicPublish<E extends DSInputElement> = {
}

type UsedPublishNames =
| 'Selected:added:pre'
| 'Selected:added'
| 'Selected:removed:pre'
| 'Selected:removed'
| 'Selectable:added:pre'
| 'Selectable:added'
| 'Selectable:removed:pre'
| 'Selectable:removed'
| 'Area:scroll:pre'
| 'Area:scroll'
| 'Interaction:start:pre'
| 'Interaction:start'
| 'Interaction:update:pre'
| 'Interaction:update'
| 'Interaction:end:pre'
| 'Interaction:end'

type UsedPublishMappings<E extends DSInputElement> = Pick<
Expand Down Expand Up @@ -139,45 +147,44 @@ export const subscriberAliases = <E extends DSInputElement>({
DS: DragSelect<E>
}) => {
const mapping: DSMappings<E> = {
'Selected:added': [
'Selected:added:pre': [
{ name: 'preelementselect' },
{ name: 'elementselect' },
{ name: 'DS:select:pre' },
{ name: 'DS:select' },
],
'Selected:removed': [
'Selected:added': [{ name: 'elementselect' }, { name: 'DS:select' }],
'Selected:removed:pre': [
{ name: 'preelementunselect' },
{ name: 'elementunselect' },
{ name: 'DS:unselect:pre' },
{ name: 'DS:unselect' },
],
'Selectable:added': [{ name: 'DS:added:pre' }, { name: 'DS:added' }],
'Selectable:removed': [{ name: 'DS:removed:pre' }, { name: 'DS:removed' }],
'Area:scroll': [
{ name: 'preautoscroll' },
{ name: 'autoscroll' },
{ name: 'DS:scroll:pre' },
{ name: 'DS:scroll' },
],
'Interaction:start': [
'Selected:removed': [{ name: 'elementunselect' }, { name: 'DS:unselect' }],
'Selectable:added:pre': [{ name: 'DS:added:pre' }],
'Selectable:added': [{ name: 'DS:added' }],
'Selectable:removed:pre': [{ name: 'DS:removed:pre' }],
'Selectable:removed': [{ name: 'DS:removed' }],
'Area:scroll:pre': [{ name: 'preautoscroll' }, { name: 'DS:scroll:pre' }],
'Area:scroll': [{ name: 'autoscroll' }, { name: 'DS:scroll' }],
'Interaction:start:pre': [
{ name: 'predragstart' },
{ name: 'dragstart' },
{ name: 'DS:start:pre' },
{ name: 'DS:start' },
],
'Interaction:update': [
'Interaction:start': [{ name: 'dragstart' }, { name: 'DS:start' }],
'Interaction:update:pre': [
{ name: 'predragmove', condition: (data) => (data.event ? data : null) },
{ name: 'dragmove', condition: (data) => (data.event ? data : null) },
{
name: 'DS:update:pre',
condition: (data) => (data.event ? data : null),
},
],
'Interaction:update': [
{ name: 'dragmove', condition: (data) => (data.event ? data : null) },
{ name: 'DS:update', condition: (data) => (data.event ? data : null) },
],
'Interaction:end': [
'Interaction:end:pre': [
{ name: 'precallback', extraData: (data, DS) => endExtraData(data, DS) },
{ name: 'callback', extraData: (data, DS) => endExtraData(data, DS) },
{ name: 'DS:end:pre', extraData: (data, DS) => endExtraData(data, DS) },
],
'Interaction:end': [
{ name: 'callback', extraData: (data, DS) => endExtraData(data, DS) },
{ name: 'DS:end', extraData: (data, DS) => endExtraData(data, DS) },
],
}
Expand Down
Loading