Merge pull request #4863 from TheThingsNetwork/fix/release

Build DLL on release tag
TheThingsNetwork · Nov 12, 2021 · a398e83 · a398e83
2 parents 09f6106 + 41ea812
commit a398e83
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/release-tag.yml b/.github/workflows/release-tag.yml
@@ -96,6 +96,8 @@ jobs:
     - name: Install JS dependencies
       run: tools/bin/mage js:deps
       timeout-minutes: 5
+    - name: Build DLLs
+      run: tools/bin/mage js:buildDll
     - name: Build frontend
       run: tools/bin/mage js:clean js:build
     - name: File versioning

diff --git a/pkg/applicationserver/io/mqtt/mqtt.go b/pkg/applicationserver/io/mqtt/mqtt.go
@@ -236,8 +236,7 @@ type topicAccess struct {
 	writes [][]string
 }
 
-func (c *connection) Connect(ctx context.Context, info *auth.Info) (context.Context, error) {
-	var err error
+func (c *connection) Connect(ctx context.Context, info *auth.Info) (_ context.Context, err error) {
 	ids := ttnpb.ApplicationIdentifiers{
 		ApplicationId: info.Username,
 	}
@@ -270,7 +269,7 @@ func (c *connection) Connect(ctx context.Context, info *auth.Info) (context.Cont
 		}
 	}()
 
-	if err = rights.RequireApplication(ctx, ids); err != nil {
+	if err := rights.RequireApplication(ctx, ids); err != nil {
 		return nil, err
 	}