func: get-msgmfastatus change filter method

TheTaylorLee · Sep 18, 2024 · d41416a · d41416a
1 parent 48c3ca8
commit d41416a
Showing 1 changed file with 19 additions and 22 deletions.
diff --git a/modules/AdminToolbox.MSGraph/public/Get-msgMFAStatus.ps1 b/modules/AdminToolbox.MSGraph/public/Get-msgMFAStatus.ps1
@@ -2,46 +2,43 @@
     .DESCRIPTION
     Get multifactor authentication status for Microsoft Azure accounts
 
-    .PARAMETER type
-    Filter the results by user type. Options are "all", "licensed", "unlicensed", "guests"
+    .PARAMETER filter
+    Add any filter accepted by the get-mguser function.
+
+    FILTER EXAMPLES:
+    Get Enabled Accounts Only:
+     "accountEnabled eq true"
+    Get Local AD Synced:
+     "OnPremisesSyncEnabled eq true"
+    Get Guests:
+     "UserType eq 'Guest'"
+    Get Licensed Members:
+     "assignedLicenses/`$count ne 0 and userType eq 'Member'"
+    Get Unlicensed Members:
+     "assignedLicenses/`$count eq 0 and userType eq 'Member'"
 
     .EXAMPLE
     Get-msgMFAStatus | export-csv .\nacc-mfastatus.csv -notypeinformation
 
     .Link
     https://github.com/TheTaylorLee/AdminToolbox
+
 #>
 
 function Get-msgMFAStatus {
 
     [CmdletBinding()]
     Param (
-        [Parameter(Position = 0, Mandatory = $false)]
-        [ValidateSet("all", "licensed", "unlicensed", "guests")]
-        [string]$type = "all"
+        [Parameter(Mandatory = $true)]
+        [string]$filter
     )
 
     #Confirm pre-requisites are met.
     Test-MSGraphRequirements -scopes "User.Read.All", “UserAuthenticationMethod.Read.All” | Out-Null
 
 
-    switch ($type) {
-        "all" {
-            $users = Get-MgUser -All
-        }
-        "licensed" {
-            $users = Get-MgUser -Filter 'assignedLicenses/$count ne 0' -All
-        }
-        "unlicensed" {
-            $users = Get-MgUser -Filter 'assignedLicenses/$count eq 0' -All
-        }
-        "guests" {
-            $users = Get-MgUser -Filter "userType eq 'Guest'" -All
-        }
-        default {
-            $users = Get-MgUser -All
-        }
-    }
+    #Get all Azure users
+    $users = get-mguser -filter $filter -All -ConsistencyLevel eventual -CountVariable Records
 
     #loop through each user account
     foreach ($user in $users) {