Skip to content

Commit

Permalink
Update cpp-lint-full.yaml
Browse files Browse the repository at this point in the history
  • Loading branch information
@TheRealArthurDent
TheRealArthurDent authored Jan 23, 2024
1 parent f2b64c5 commit 62c4a69
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/cpp-lint-full.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
push:
branches:
- main
- 'renovate/cpp-linter-**'
- renovate/cpp-linter-**
workflow_dispatch:

jobs:
Expand Down

1 comment on commit 62c4a69

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format reports: 9 file(s) not formatted
  • src/main.cpp
  • src/metronome.cpp
  • src/dummy-wifi-dependent.cpp
  • src/wifi-connection.cpp
  • src/debug.cpp
  • include/wifi-dependent.hpp
  • include/dummy-wifi-dependent.hpp
  • include/metronome.hpp
  • include/wifi-connection.hpp
clang-tidy reports: 17 concern(s)

  • include/debug.h

    include/debug.h:3:10: error: [clang-diagnostic-error]

    'Arduino.h' file not found

    #include <Arduino.h>
         ^

  • src/main.cpp

    src/main.cpp:1:10: error: [clang-diagnostic-error]

    'Arduino.h' file not found

    #include <Arduino.h>
         ^

    src/main.cpp:13:11: warning: [cppcoreguidelines-avoid-non-const-global-variables]

    variable 'metronome' is non-const and globally accessible, consider making it const

    Metronome metronome(LOOP_DURATION);
          ^

    src/main.cpp:29:30: warning: [cppcoreguidelines-init-variables]

    variable 'deps' is not initialized

      std::list<WifiDependent *> deps;
                             ^
                                  = 0

  • src/metronome.cpp

    src/metronome.cpp:1:10: error: [clang-diagnostic-error]

    'Arduino.h' file not found

    #include <Arduino.h>
         ^

  • src/dummy-wifi-dependent.cpp

    include/debug.h:3:10: error: [clang-diagnostic-error]

    'Arduino.h' file not found

    #include <Arduino.h>
         ^

  • src/wifi-connection.cpp

    src/wifi-connection.cpp:47:22: warning: [modernize-use-trailing-return-type]

    use a trailing return type for this function

    bool WifiConnection::isConnected()
~~~~                 ^
auto                               -> bool

    src/wifi-connection.cpp:47:22: warning: [readability-make-member-function-const]

    method 'isConnected' can be made const

    bool WifiConnection::isConnected()
                     ^
                                   const

    src/wifi-connection.cpp:84:22: warning: [readability-convert-member-functions-to-static]

    method 'onWifiConnect' can be made static

    void WifiConnection::onWifiConnect(const WiFiEventStationModeGotIP &event)
                     ^
static

    src/wifi-connection.cpp:95:22: warning: [readability-convert-member-functions-to-static]

    method 'onWifiDisconnect' can be made static

    void WifiConnection::onWifiDisconnect(const WiFiEventStationModeDisconnected &event)
                     ^
static

    include/wifi-connection.hpp:3:10: error: [clang-diagnostic-error]

    'ESP8266WiFi.h' file not found

    #include <ESP8266WiFi.h>
         ^

  • src/debug.cpp

    include/debug.h:3:10: error: [clang-diagnostic-error]

    'Arduino.h' file not found

    #include <Arduino.h>
         ^

  • include/metronome.hpp

    include/metronome.hpp:11:7: warning: [cppcoreguidelines-special-member-functions]

    class 'Metronome' defines a copy constructor and a copy assignment operator but does not define a destructor, a move constructor or a move assignment operator

    class Metronome
      ^

    include/metronome.hpp:46:14: warning: [modernize-use-trailing-return-type]

    use a trailing return type for this function

      Metronome &operator=(Metronome const &); // hide assignment operator.
  ~~~~~~~~~~~^
  auto                                    -> Metronome &

  • include/wifi-connection.hpp

    include/wifi-connection.hpp:3:10: error: [clang-diagnostic-error]

    'ESP8266WiFi.h' file not found

    #include <ESP8266WiFi.h>
         ^

    include/wifi-connection.hpp:19:7: warning: [cppcoreguidelines-pro-type-member-init]

    constructor does not initialize these fields: wifiConnectHandler, wifiDisconnectHandler, dependents

    class WifiConnection
      ^

    include/wifi-connection.hpp:40:3: warning: [cppcoreguidelines-pro-type-member-init]

    constructor does not initialize these fields: wifiConnectHandler, wifiDisconnectHandler, dependents

      WifiConnection() = default;                 // hide default constructor
  ^

Have any feedback or feature suggestions? Share it here.

Please sign in to comment.