-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color picker picks the color *after* browser/application color management #76
Comments
https://twitter.com/davatron5000/status/1129397925409415168 Reduced test case: https://codepen.io/davatron5000/pen/JqJYob From tweet:
Follow-up tweet:
|
I did some research and testing today. The only solution I found to get correct values is to set my screen color profile to sRGB. |
suggest in worst case removing the picker then...as it's misleading/inaccurate otherwise (and forcing users to change their color profile is a no-go i'd say) |
I'm also investigating some other possibilities: |
Do not like. The picker is the feature that I rely on with this tool, particularly when grabbing colors from images and gradients. Yes, I can rely on other tools for a picker, but then I have no reason to use this one any longer. Suggest a warning with the picker, assuming no other solution available. |
@aardrian so you'd rather have a picker that's not guaranteed to be correct, and tells you so when you use it? personally, i'd posit that if the picker cannot be fixed, we may gracefully retire the tool...because yes i agree the picker is the selling point here really... |
Yes. Because as a user I can adjust the color profile or jump to a browser (Firefox) that does not use the profile. Provided the warning is clear and actionable. |
@ferllings Did you find a way to switch the color profile? The Digital Color Meter by Apple also has such an option to select sRGB instead of Native Values.
+1 from me. |
@andreasbossard Sorry, I have to admit I haven't found the time to work on CCA since July. But this is on top of my todo list. |
Slow progress: I have difficulties to get the appropriate colorProfile information in order to make the conversion. The new Electron v6 introduced a new display attribute "colorSpace", So I decided to find an alternative way for the picker, and get rid of robotjs. |
Any chance a warning can be added to the tool to let people know what is going on - this causes considerable issues. |
Is this still a current issue? I upgraded from an old release (1.2.1) to 3.3.0 on macOS and that fixed it for me. |
purely testing with |
I believe it also depends of your monitor colorspace. I need to do more tests |
macOS: Firefox seems impacted now, and switching the display color profile to sRGB is still a functional workaround. I recently ran into this on macOS 14.4, including when using Firefox 124.0 esr, on the build-in display of a recent MacBook Pro 16-inch, Nov 2023. It was not detectable using the earlier-shared Contrast Tester Tester codepen as-is, but it was when I tweaked the background color to be 00EE00, which gets read as 07EE00. It seemed to be related to the default Display P3 colorspace of the laptop monitor at fault. Switching to sRBG made the display really dim, with display brightness control locked out, but it did give the expected readings of 00EE00. (Another fun gotcha to watch out for on a smaller screen is the shadow that macOS places around windows, which can darken the picked color if you don't move the CCA window well clear first.) TrueTone surprisingly did not seem to have any impact, on or off. |
On both Windows and macOS, some browsers (and other applications) apply their own color management to CSS color values before displaying them. This means that, depending on the user's specific color profile, the actual colors displayed don't necessarily match the CSS values. But the CCA's picker picks up the displayed (already color managed) colors...leading to inaccurate picks.
On Windows, it seems that currently only Chrome applies color management for CSS colors. Edge and Firefox don't.
On macOS, Chrome and Safari apply color management, while Firefox doesn't.
Not sure if there's a simple workaround for this. Just testing in macOS using a graphics app and firing up its (native) color selection dialog, the eyedropper there corrects for this. Perhaps there's a way to trigger the platform's own picker - but I'm not aware of a similar OS-level native picker on Windows.
The text was updated successfully, but these errors were encountered: