Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The sampling of colours is different #278

Closed
thvi opened this issue Feb 5, 2023 · 8 comments
Closed

The sampling of colours is different #278

thvi opened this issue Feb 5, 2023 · 8 comments
Labels
duplicate This issue or pull request already exists

Comments

@thvi
Copy link

thvi commented Feb 5, 2023

Hello,
Colour Contrast Analyser (CCA)
v. 3.1.2 doesn't work correctly
Best.

@ferllings
Copy link
Member

I removed your link for security purpose, as the target was not clearly identifiable.
Please attach an image instead.

@diprosew
Copy link

I agree with thvi, the eyedropper sampler results are incorrect.
Proof in point: Type in 100% red HEX value into the input field, i.e. #FF0000, then sample the displayed color and the resultant sample is not the same. The rgb values say it all; The result is rgb(247, 0, 12).
100% green/rgb(0, 255, 0) when sampled becomes rgb(72, 254, 0)

@ferllings
Copy link
Member

ferllings commented Feb 16, 2023

The result may vary according to your screen and the app color profiles. See #76

@thvi
Copy link
Author

thvi commented Feb 16, 2023

ezgif-5-94902427ac

@thvi
Copy link
Author

thvi commented Feb 16, 2023

The accessibility ratios are different.
Screenshot 2023-02-16 at 8 57 18 AM

@ferllings
Copy link
Member

That's what I'm saying, if figma and CCA are not in the same color space, you may have different results

@thvi
Copy link
Author

thvi commented Feb 16, 2023

That's what I'm saying, if figma and CCA are not in the same color space, you may have different results

So, how can I resolve it?

@ferllings
Copy link
Member

As described in #76, that's not an easy problem. (If you application allows it) You need everything in the same color space

@ferllings ferllings added the duplicate This issue or pull request already exists label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants