Fracking Tower And Bedrock Oil Deposit #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 30, 2023 20:51
…e fracking tower. Added the bedrock oil deposit. There oily and dead dirt above the deposits on ground. Took some duplicate code from the oil drillers and made a class that has that, so no duplicate code (mostly, because then the 1.7.10 and 1.12.2 code look more similiar and my brain does not explode). Yes I know that I should have done multiple commits, but I learned about this commit thing only after I googled how to do pull requests when I had already done everything.
… if it is an bedrock oil deposit, the others don't need it, but it removes some duplicate code. Also changed the succ() to use byte instead of int, because it doesn't need it. (I made the thing that it tells is it bedrock oil deposit, so I just fixed my own mistake but...) Also removed the max depth from the fracking tower, so it can actually reach all way to the bedrock oil deposits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Fracking Tower.
Added Fracking Solution.
Added Dead Plants and all the other polluted stuff, because of the tower.
Added Bedrock Oil Deposit
Took some duplicate code and put it to TileEntityOilDrillBase. (that was how it was done in the 1.7.10 version and my brain doesn't explode when the code looks more similiar to that, so that's pretty much the real reason for that.)
The tower will pollute the nearby environment by killing plants and all that stuff.
Bedrock oil deposit has that dead stuff over it on the ground so you can find it easier.
I'm not sure if the code is absolutely horrible (this is my second time of modding of any kind), but we'l see.
This is also second time making this this pull request, because I failed horribly making this first time.