Skip to content

Commit

Permalink
Recorrect feature requirements in projects
Browse files Browse the repository at this point in the history
Signed-off-by: Tobias Frisch <[email protected]>
  • Loading branch information
TheJackiMonster committed Jul 19, 2024
1 parent f920668 commit e3f0db2
Show file tree
Hide file tree
Showing 8 changed files with 0 additions and 56 deletions.
8 changes: 0 additions & 8 deletions projects/fire_works/src/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -201,14 +201,6 @@ int main(int argc, const char **argv) {
features.requireFeature([](vk::PhysicalDeviceFeatures& features) {
features.setGeometryShader(true);
});

features.requireExtensionFeature<vk::PhysicalDeviceDescriptorIndexingFeatures>(
VK_EXT_DESCRIPTOR_INDEXING_EXTENSION_NAME,
[](vk::PhysicalDeviceDescriptorIndexingFeatures& features) {
features.setDescriptorBindingPartiallyBound(true);
features.setDescriptorBindingVariableDescriptorCount(true);
}
);

vkcv::Core core = vkcv::Core::create(
"Firework",
Expand Down
8 changes: 0 additions & 8 deletions projects/indirect_dispatch/src/App.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,6 @@ static vkcv::Features getAppFeatures() {
features.setShaderFloat16(true);
}
);

features.requireExtensionFeature<vk::PhysicalDeviceDescriptorIndexingFeatures>(
VK_EXT_DESCRIPTOR_INDEXING_EXTENSION_NAME,
[](vk::PhysicalDeviceDescriptorIndexingFeatures& features) {
features.setDescriptorBindingPartiallyBound(true);
features.setDescriptorBindingVariableDescriptorCount(true);
}
);

features.tryExtensionFeature<vk::PhysicalDeviceCoherentMemoryFeaturesAMD>(
VK_AMD_DEVICE_COHERENT_MEMORY_EXTENSION_NAME,
Expand Down
8 changes: 0 additions & 8 deletions projects/mesh_shader/src/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -90,14 +90,6 @@ int main(int argc, const char** argv) {
}
);

features.requireExtensionFeature<vk::PhysicalDeviceDescriptorIndexingFeatures>(
VK_EXT_DESCRIPTOR_INDEXING_EXTENSION_NAME,
[](vk::PhysicalDeviceDescriptorIndexingFeatures& features) {
features.setDescriptorBindingPartiallyBound(true);
features.setDescriptorBindingVariableDescriptorCount(true);
}
);

vkcv::Core core = vkcv::Core::create(
applicationName,
VK_MAKE_VERSION(0, 0, 1),
Expand Down
7 changes: 0 additions & 7 deletions projects/particle_simulation/src/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,6 @@ int main(int argc, const char **argv) {

vkcv::Features features;
features.requireExtension(VK_KHR_SWAPCHAIN_EXTENSION_NAME);
features.requireExtensionFeature<vk::PhysicalDeviceDescriptorIndexingFeatures>(
VK_EXT_DESCRIPTOR_INDEXING_EXTENSION_NAME,
[](vk::PhysicalDeviceDescriptorIndexingFeatures& features) {
features.setDescriptorBindingPartiallyBound(true);
features.setDescriptorBindingVariableDescriptorCount(true);
}
);

vkcv::Core core = vkcv::Core::create(
applicationName,
Expand Down
8 changes: 0 additions & 8 deletions projects/path_tracer/src/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,6 @@ int main(int argc, const char** argv) {
vkcv::Features features;
features.requireExtension(VK_KHR_SWAPCHAIN_EXTENSION_NAME);

features.requireExtensionFeature<vk::PhysicalDeviceDescriptorIndexingFeatures>(
VK_EXT_DESCRIPTOR_INDEXING_EXTENSION_NAME,
[](vk::PhysicalDeviceDescriptorIndexingFeatures& features) {
features.setDescriptorBindingPartiallyBound(true);
features.setDescriptorBindingVariableDescriptorCount(true);
}
);

vkcv::Core core = vkcv::Core::create(
applicationName,
VK_MAKE_VERSION(0, 0, 1),
Expand Down
8 changes: 0 additions & 8 deletions projects/ray_tracer/src/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,6 @@ int main(int argc, const char** argv) {
vkcv::Features features;
features.requireExtension(VK_KHR_SWAPCHAIN_EXTENSION_NAME);

features.requireExtensionFeature<vk::PhysicalDeviceDescriptorIndexingFeatures>(
VK_EXT_DESCRIPTOR_INDEXING_EXTENSION_NAME,
[](vk::PhysicalDeviceDescriptorIndexingFeatures& features) {
features.setDescriptorBindingPartiallyBound(true);
features.setDescriptorBindingVariableDescriptorCount(true);
}
);

vkcv::Core core = vkcv::Core::create(
applicationName,
VK_MAKE_VERSION(0, 0, 1),
Expand Down
8 changes: 0 additions & 8 deletions projects/sph/src/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,6 @@ int main(int argc, const char **argv) {
vkcv::Features features;
features.requireExtension(VK_KHR_SWAPCHAIN_EXTENSION_NAME);

features.requireExtensionFeature<vk::PhysicalDeviceDescriptorIndexingFeatures>(
VK_EXT_DESCRIPTOR_INDEXING_EXTENSION_NAME,
[](vk::PhysicalDeviceDescriptorIndexingFeatures& features) {
features.setDescriptorBindingPartiallyBound(true);
features.setDescriptorBindingVariableDescriptorCount(true);
}
);

// creating core object that will handle all vulkan objects
vkcv::Core core = vkcv::Core::create(
applicationName,
Expand Down
1 change: 0 additions & 1 deletion src/vkcv/ShaderProgram.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ namespace vkcv {
for (uint32_t i = 0; i < res->size(); i++) {
const spirv_cross::Resource &u = (*res)[i];
const spirv_cross::SPIRType &base_type = comp.get_type(u.base_type_id);
const spirv_cross::SPIRType &type = comp.get_type(u.type_id);

uint32_t setID = comp.get_decoration(u.id, spv::DecorationDescriptorSet);
uint32_t bindingID = comp.get_decoration(u.id, spv::DecorationBinding);
Expand Down

0 comments on commit e3f0db2

Please sign in to comment.