Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Several Conversions #2334

Open
wants to merge 28 commits into
base: master
Choose a base branch
from

Conversation

unknown117343
Copy link
Contributor

@unknown117343 unknown117343 commented Jan 8, 2025

  • Added images to class, subclasses, bookdata, and book cover
  • Added dateAdded based off of first commit
  • Added additional tagging
  • Fixed class fluff not showing
  • Fixed typos
  • Fixed subclass feature headers
  • Changed url to take folks to the PDF
  • Changed color of abbreviation to better match the cover






  • Added images to class, subclasses, bookdata, and book cover
  • Added images to several creatures
  • Added Companion tag to companions
  • Added additional tagging
  • Added summonedScaleByPlayerLevel for companions
  • Fixed subclass feature headers
  • Fixed typos
  • Changed title to Beastheart and Monstrous Companions
  • Changed author to MCDM Productions like the rest of MCDM brews
  • Changed color of abbreviation to better match the cover






  • Added several item images
  • Added an image & token to a creature
  • Added cover to adventures
  • Fixed broken url link
  • Changed color of abbreviation to better match the cover






  • Added Retainer tag to retainers
  • Fixed misclassified rarity of one magic item
  • Changed several images to have transparency
  • Changed author to MCDM Productions like the rest of MCDM brews






  • Added summonedScaleByPlayerLevel for retainers
  • Added page numbers for retainers






  • Added images & tokens to several creatures
  • Added summonedScaleByPlayerLevel for retainers/companions
  • Fixed typos






  • Changed several monster images to have transparency






- Fixed Druid subclass causing the page to load improperly as reported in

Discord






  • Fixed reported typo

@unknown117343 unknown117343 marked this pull request as ready for review January 12, 2025 01:50
Copy link
Owner

@TheGiddyLimit TheGiddyLimit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the image changes, please do move them over to https://github.com/TheGiddyLimit/homebrew-img -- the remaining images in this repo are to avoid breaking e.g. existing Foundry imports, so anything which is going to break links anyway (like converting to webp) should move them to the dedicated repo at the same time

since just reverting the changes would leave a nasty pile of junk diffs in the history, you'll either need to amend your existing commits and force-push, or just re-make this PR off a clean branch, without the new images. Without looking at the commits, the latter might be easier!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants