Jellyfin Dev #257
Merged
Jellyfin Dev #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the artwork data cannot be found, it will be replaced with a placeholder provided by media player
…e app icon as a placeholder
…e is this is sometimes 0 even though something is playing
…p button is pressed or the source modifies the elapsedTime after being paused
…edDisplay so that boringNotch remembers the last manually selected screen and tries to use it if it is available
…ated onChange calls
…el to BoringView Coordinator. This will help isolate the singleton-required code from the ViewModel that is now specific to each window.
… add new show on all displays beta option
…creens (seperate control from non-notched displays)
If the artwork data cannot be found, it will be replaced with a placeholder provided by media player
…e app icon as a placeholder
…e is this is sometimes 0 even though something is playing
…p button is pressed or the source modifies the elapsedTime after being paused
This was
linked to
issues
Jan 14, 2025
theboringhumane
had a problem deploying
to
github-pages
GitHub Actions
Failure
|
Hey @theboringhumane! 👋 Just wrapped up reviewing your code! Here's what I found:
Feel free to ping me if anything's not clear or if you want to chat about any of the suggestions! I'm here to help you ship awesome code! 🚀 Cheers! 🦦 |
- Add conditional frame adjustments for calendar and mirror\n- Improve frame calculations readability\n- Fix compiler type-checking issues
- Add file name, line number and function name to logs\n- Implement emoji-based log categories\n- Add utility functions for consistent logging
- Refactor BoringViewModel for better state management\n- Update constants for frame calculations\n- Improve code organization
- Remove deprecated NotchContentView\n- Update BoringHeader layout\n- Improve NotchHomeView organization
- Enhance CalendarManager functionality\n- Improve MusicManager state handling\n- Add better error handling
- Improve size calculations for calendar and mirror\n- Add new sizing constants\n- Optimize frame dimension logic
- Enhance settings view layout\n- Improve tab selection behavior\n- Update webcam view functionality
- Removed NotchContentView from project references
- Remove additional padding from contentRect in BoringNotchWindow initialization - Ensure consistent window sizing across different display settings
- Update current project version to 2.4+1 and marketing version to 2.4
- Add "Access Denied" localization entry - Remove unused "ERROR: VIEW NOT DEFINED" entry - Ensure proper formatting and structure in Localizable.xcstrings
- Change default release name from "Glowing Panda 🐼 (Snooty)" to "Jolly Dolphin 🐬 (Dreaming)" in Constants.swift - Ensure consistency in naming conventions for better clarity
- Introduced details for version 2.4 of Jolly Dolphin 🐬, highlighting exciting new features and improvements. - Included a comprehensive description of changes, including memory leak fixes, AirDrop enhancements, and UI responsiveness improvements. - Updated appcast.xml to reflect the latest release and provide users with relevant update information.
- Eliminated the unnecessary transition modifier from the main content view in NotchHomeView.swift to streamline the view rendering process. - Ensured that the transition effects remain consistent and optimized for performance.
…sic management features - Integrated new options for hiding the notch during fullscreen media playback, allowing users to choose between always hiding, hiding only when the NowPlaying app is in fullscreen, or never hiding. - Updated the SettingsView to include the new hide notch options and improved the layout for better user experience. - Refactored MusicManager to streamline state handling and ensure proper updates to the UI based on media playback status. - Added support for the `MacroVisionKit` to enhance fullscreen detection capabilities.
…ions and animations - Improved padding and transition effects in ContentView to enhance user experience when interacting with the notch. - Updated BoringHeader to refine animation delays for smoother transitions based on notch state. - Adjusted scale effect in NotchHomeView's AlbumArtView for better visual presentation. - Cleaned up code formatting and removed unnecessary whitespace for improved readability.
- Removed unnecessary whitespace and improved formatting in WebcamView.swift, WebcamManager.swift, and matters.swift for better code clarity. - Streamlined method calls in WebcamManager to enhance readability. - Adjusted spacing and formatting in sizeMatters.swift to maintain consistency across the codebase.
theboringhumane
had a problem deploying
to
github-pages
GitHub Actions
Failure
|
Hey @theboringhumane! 👋 Just wrapped up reviewing your code! Here's what I found:
Feel free to ping me if anything's not clear or if you want to chat about any of the suggestions! I'm here to help you ship awesome code! 🚀 Cheers! 🦦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.