Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Improvements: Improved Animations & Blur, Fixed Notch Shape, and more! #223

Open
wants to merge 61 commits into
base: dev
Choose a base branch
from

Conversation

OmChachad
Copy link

@OmChachad OmChachad commented Nov 23, 2024

I've made a bunch of changes to make the experience for users significantly better! The Boring Notch Experience is now closer to that of the official Apple Dynamic Island on an iPhone. I think users will really appreciate these changes!

The following are all the changes that have been made:

  • Updated Open/Close Animation to match iOS Behavior
  • Added Blur Effect, and reduced existing blur delay to match iOS Behavior
  • Album Artwork now shrinks, and reduces in opacity when media is paused.
  • The playback slider is now more response to dragging, has a larger click target, and responds only to hovers.
  • Increased Play Button Size relative to other buttons.
  • Reduced the Artwork Glow size so that it no longer interferes with the physical notch, to ensure the physical notch stays as hidden as possible.
  • Matched Artwork and Notch Corner Radius
  • The Notch Shape is corrected to be perfectly symmetric and matches the physical notch closely. Previously, the shape was slightly jagged and did not perfectly fit the physical notch.
  • Added Matched Geometry Effect to Spectrum
  • Added Safe Area for Hover Zone: Added a 30px safe area around the notch to keep the notch from closing instantly as soon as the cursor exits.
  • Reduced Padding Between Song Name and Artist Name

Preview: https://github.com/user-attachments/assets/55056829-7c6d-4f95-9a88-09326a2d5eff

overflow-sudo and others added 30 commits November 3, 2024 09:22
If the artwork data cannot be found, it will be replaced with a placeholder provided by media player
…e is this is sometimes 0 even though something is playing
…p button is pressed or the source modifies the elapsedTime after being paused
…it the event view into two VStacks to allow for the circles and event titles to be allgned regardless of start and end time string length
…edDisplay so that boringNotch remembers the last manually selected screen and tries to use it if it is available
@OmChachad
Copy link
Author

Hey @OmChachad Great work. Really nice changes. Can you please check the matchedGeometryEffect of visualizer when Calendar and Mirror are turned off? It seems it has some issues with the transition while opening.

Thanks! Can you share a recording of the issue please, I can't find any glitches when opening myself 😅

@fofsinx
Copy link
Member

fofsinx commented Nov 23, 2024

git rebase origin/dev then solve the merge conflicts.

@fofsinx
Copy link
Member

fofsinx commented Nov 23, 2024

@OmChachad wait let me fix the main and dev commit history!

@OmChachad
Copy link
Author

@OmChachad wait let me fix the main and dev commit history!

Okay let me know

@OmChachad
Copy link
Author

@OmChachad Also try to add a sqash animation as song changes just like ios, that would be cool.

Are you referring to the animation to the artwork when changing a song? Certainly possible, will work on that!

Yeah

Will work on this for a future PR!

@OmChachad
Copy link
Author

@OmChachad wait let me fix the main and dev commit history!

Excuse my naiveness, but I have no clue how to rebase in GitHub Desktop... Is there a different way to go about this?

@OmChachad
Copy link
Author

OmChachad commented Nov 24, 2024

Alright, I figured it out!! 🙌🏻

There's an issue with the hover animation though. Now, whenever the cursor is in the region of the physical notch, the Apple Music Icon slightly peaks from the bottom twice...

Screenshot 2024-11-24 at 4 02 07 PM

@OmChachad
Copy link
Author

Nevermind. I just spent 30 minutes debugging a bug that never existed. I just had two instances of the app running at once, which caused that glitch...

All good now, ready to merge!

@OmChachad
Copy link
Author

Hey, any update? 😃

@Alexander5015 Alexander5015 removed their request for review November 28, 2024 01:03
@fofsinx
Copy link
Member

fofsinx commented Nov 28, 2024

I'll test it locally maybe today. @OmChachad been busy.

@fofsinx
Copy link
Member

fofsinx commented Nov 28, 2024

@OmChachad Can you fix the conflicts.

git rebase origin/dev

@OmChachad
Copy link
Author

Done! I thought I did, but not sure what happened…

@fofsinx
Copy link
Member

fofsinx commented Nov 29, 2024

I updated the dev branch.

@OmChachad
Copy link
Author

Fixed the compiling issue!

@richardkunkli richardkunkli linked an issue Dec 1, 2024 that may be closed by this pull request
@fofsinx
Copy link
Member

fofsinx commented Dec 2, 2024

@OmChachad this is not ready for merge yet.

set this https://github.com/TheBoredTeam/boring.git as one of the remote

run git rebase remote/dev

@fofsinx
Copy link
Member

fofsinx commented Dec 2, 2024

cc @richardkunkli

@albinkc
Copy link

albinkc commented Dec 7, 2024

hoping a git expert chimes in

@fofsinx
Copy link
Member

fofsinx commented Dec 7, 2024

Either @Alexander5015 or @OmChachad have to fix these conflicts.

@Alexander5015
Copy link
Member

I don't see any conflicts, I think @richardkunkli is going to make a change when he has a chance and then he can merge it

@OmChachad
Copy link
Author

yeah, I don't see any conflicts either; not really able to do anything here 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Media art gradient reveals notch.
7 participants