Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs, test: Fit bubble_sort into guidelines and enhance bubble sort algorithm #2800

Merged
merged 9 commits into from
Oct 11, 2024
Merged

docs, test: Fit bubble_sort into guidelines and enhance bubble sort algorithm #2800

merged 9 commits into from
Oct 11, 2024

Conversation

hollowcrust
Copy link
Contributor

Description of Change

  • Add namespaces, tests and documentations according to current guidelines.
  • Generalising data type for bubble sort algorithm so that the algorithm can be applied to an array of any data type.

Checklist

  • Added description of change
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:
For Hacktoberfest, for #2456

realstealthninja
realstealthninja requested changes Oct 9, 2024
View reviewed changes
sorting/bubble_sort.cpp Show resolved Hide resolved
sorting/bubble_sort.cpp Outdated Show resolved Hide resolved
sorting/bubble_sort.cpp Outdated Show resolved Hide resolved
sorting/bubble_sort.cpp Outdated Show resolved Hide resolved
sorting/bubble_sort.cpp Show resolved Hide resolved
@realstealthninja realstealthninja added the awaiting modification Do not merge until modifications are made label Oct 9, 2024
realstealthninja
realstealthninja approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@realstealthninja realstealthninja added hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 10, 2024
@realstealthninja realstealthninja added approved Approved; waiting for merge and removed awaiting modification Do not merge until modifications are made labels Oct 10, 2024
@hollowcrust
Copy link
Contributor Author

LGTM!

Thanks! Can you please help me check #2779 as well?

@realstealthninja realstealthninja merged commit 136e6c0 into TheAlgorithms:master Oct 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realstealthninja realstealthninja realstealthninja approved these changes

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7 Panquesito7 is a code owner

Assignees
No one assigned
Labels
approved Approved; waiting for merge hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hollowcrust @realstealthninja