Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix/docs]: fit check_amicable_pair.cpp to guidelines #2465

Merged
merged 10 commits into from
Jun 23, 2023
Merged

[fix/docs]: fit check_amicable_pair.cpp to guidelines #2465

merged 10 commits into from
Jun 23, 2023

Conversation

ewd00010
Copy link
Contributor

Description of Change

FIX: initlized sum to 1 instead of adding it before return
CHORE: cleaned documentation aswell as adding new documentation, namespace math added

Checklist

  • Added description of change
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • I acknowledge that all my contributions will be made under the project's license.

Notes: could use clang-tidy check like my previous pull requests

@ewd00010
Quality of life
f7a2e3d 
FIX:  initlized sum to 1 instead of adding it before return
CHORE: cleaned documentation aswell as adding new documentation, namespace math added
realstealthninja
realstealthninja requested changes May 23, 2023
View reviewed changes
math/check_amicable_pair.cpp Outdated Show resolved Hide resolved
@realstealthninja
Copy link
Collaborator

part of #2456

realstealthninja
realstealthninja previously approved these changes May 27, 2023
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pr. We greatly appreciate your help here. Now the maintainers will review your pr! ❤️

@Panquesito7 Panquesito7 added bugfix Correction to existing algorithms enhancement New feature or request and removed bugfix Correction to existing algorithms labels May 30, 2023
Panquesito7
Panquesito7 requested changes May 30, 2023
View reviewed changes
math/check_amicable_pair.cpp Outdated Show resolved Hide resolved
math/check_amicable_pair.cpp Outdated Show resolved Hide resolved
realstealthninja
realstealthninja previously approved these changes Jun 19, 2023
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! great work

Panquesito7
Panquesito7 previously approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks! 🚀

realstealthninja
realstealthninja previously approved these changes Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@Panquesito7 Panquesito7 changed the title fix:fit check_amicable_pair.cpp to guidelines [fix/docs]: fit check_amicable_pair.cpp to guidelines Jun 23, 2023
@Panquesito7 Panquesito7 merged commit e3f0551 into TheAlgorithms:master Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@realstealthninja realstealthninja realstealthninja left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ewd00010 @realstealthninja @Panquesito7