Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second Red Black Tree Program #1968

Closed
wants to merge 68 commits into from

Conversation

brennandoubt
Copy link

@brennandoubt brennandoubt commented Aug 4, 2022

Description of Change

I think this variation of the red black tree data structure has helpful additional documentation and naming for functions/variables to make it clearer how different parts of a red black tree's source code work. I started the program as a college homework assignment but all of the code and implementation methods are my own. I'm happy to update or fix anything with my code if needed!

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

I think my variation has helpful additional documentation and naming for functions/variables to make it clearer how different parts of a red black tree's source code work. I started the program as a college homework assignment but all of the code and implementation methods are my own. I'm happy to update or fix anything with my code if needed!
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! Thank you for submitting a PR! 😄 Sadly, this does not meet our requirements. Check out our repository standards. Please read them carefully and follow them. Let us know if you need any help here or on our Discord server. 🙂

__
sema-logo  Summary: 🛠️ This code needs a fix  |  Tags: Not maintainable

@Panquesito7 Panquesito7 added enhancement New feature or request automated tests are failing Do not merge until tests pass requested changes changes have been requested Proper Documentation Required requested to write the documentation properly labels Aug 21, 2022
@brennandoubt
Copy link
Author

Thanks for the reply! I'm working on fixing the code right now. If it just said that I tried to merge my branch again, then I did that by mistake and am still working on the repo.

@brennandoubt
Copy link
Author

I updated my branch with the updated red black tree program!

data_structures/rb_tree2.cpp Outdated Show resolved Hide resolved
data_structures/rb_tree2.cpp Outdated Show resolved Hide resolved
@brennandoubt
Copy link
Author

Should I make sure all linter suggestions are added to my code? I have a couple of tests that have assert statements over 80 characters long, but I wasn't sure if it'd be preferred to just remove the longer test lines I have.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2022

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Author has not responded to the comments for over 2 weeks label Oct 2, 2022
@brennandoubt
Copy link
Author

brennandoubt commented Oct 2, 2022 via email

@github-actions github-actions bot removed the stale Author has not responded to the comments for over 2 weeks label Oct 3, 2022
@Panquesito7
Copy link
Member

Hello. It'd be great if you could fix all the linter warnings/errors. These are to ensure your code matches our guidelines.
You can always reach out to us if you need any help! Feel free to join our Discord server. 🙂

data_structures/rb_tree2.cpp Outdated Show resolved Hide resolved
@brennandoubt
Copy link
Author

Should I be concerned about the gh-pages step failing in the workflow? I updated my fork and think I also fixed the issue causing the windows compile check to fail.

not at all gh-pages can only be built on the main repo

Thanks! I thought so but wanted to make sure I wasn't missing something

@brennandoubt
Copy link
Author

And if there's anything else left to do, please let me know!

@brennandoubt
Copy link
Author

Hi, just checking again if there's anything else left to do for the RBT algorithm

Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Author has not responded to the comments for over 2 weeks label Oct 9, 2023
@brennandoubt
Copy link
Author

Hi, is there anything else that needs to be done for my program?

@github-actions github-actions bot removed the stale Author has not responded to the comments for over 2 weeks label Oct 10, 2023
@brennandoubt
Copy link
Author

Any updates?

Copy link
Contributor

github-actions bot commented Jan 8, 2024

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Author has not responded to the comments for over 2 weeks label Jan 8, 2024
@brennandoubt
Copy link
Author

Hi, is there any update? Or could I have a re-review from @Panquesito7 on my code?

@github-actions github-actions bot removed the stale Author has not responded to the comments for over 2 weeks label Jan 10, 2024
Copy link
Contributor

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Author has not responded to the comments for over 2 weeks label Feb 10, 2024
@brennandoubt
Copy link
Author

Any update?

@github-actions github-actions bot removed the stale Author has not responded to the comments for over 2 weeks label Feb 11, 2024
Copy link
Contributor

github-actions bot commented Apr 2, 2024

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Author has not responded to the comments for over 2 weeks label Apr 2, 2024
Copy link
Contributor

github-actions bot commented Apr 9, 2024

Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions!

@github-actions github-actions bot closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated tests are failing Do not merge until tests pass enhancement New feature or request stale Author has not responded to the comments for over 2 weeks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants