-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Second Red Black Tree Program #1968
Conversation
I think my variation has helpful additional documentation and naming for functions/variables to make it clearer how different parts of a red black tree's source code work. I started the program as a college homework assignment but all of the code and implementation methods are my own. I'm happy to update or fix anything with my code if needed!
Second red black tree program
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! Thank you for submitting a PR! 😄 Sadly, this does not meet our requirements. Check out our repository standards. Please read them carefully and follow them. Let us know if you need any help here or on our Discord server. 🙂
__
Summary: 🛠️ This code needs a fix | Tags: Not maintainable
Thanks for the reply! I'm working on fixing the code right now. If it just said that I tried to merge my branch again, then I did that by mistake and am still working on the repo. |
I updated my branch with the updated red black tree program! |
Co-authored-by: David Leal <[email protected]>
Co-authored-by: David Leal <[email protected]>
Should I make sure all linter suggestions are added to my code? I have a couple of tests that have assert statements over 80 characters long, but I wasn't sure if it'd be preferred to just remove the longer test lines I have. |
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hi, I posted a question on the pull request about if I need to apply all of the linter suggestions for my program, mainly for my longer code lines that hold larger data structures to test on. I wasn’t sure if I just need to remove my larger tests for my program in order to pass the linter code check or if it’s possible to leave them and apply linter’s other suggestions for cleaning up my code aside from the suggestions to shorten certain lines of code.
Is there a specific time when the pull request will be closed before any more activity occurs on it?
Thanks in advance!
Brennan
… Am 02.10.2022 um 02:17 schrieb github-actions[bot] ***@***.***>:
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
—
Reply to this email directly, view it on GitHub <#1968 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVQX5SA73OLNEKYP752IJA3WBDIB5ANCNFSM55SJ2AAQ>.
You are receiving this because you authored the thread.
|
Hello. It'd be great if you could fix all the linter warnings/errors. These are to ensure your code matches our guidelines. |
Thanks! I thought so but wanted to make sure I wasn't missing something |
And if there's anything else left to do, please let me know! |
Hi, just checking again if there's anything else left to do for the RBT algorithm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hi, is there anything else that needs to be done for my program? |
Any updates? |
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hi, is there any update? Or could I have a re-review from @Panquesito7 on my code? |
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Any update? |
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions! |
Description of Change
I think this variation of the red black tree data structure has helpful additional documentation and naming for functions/variables to make it clearer how different parts of a red black tree's source code work. I started the program as a college homework assignment but all of the code and implementation methods are my own. I'm happy to update or fix anything with my code if needed!
Checklist
Notes: