Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MEDIUM CODE RUB: Upgrade to The Standard 2.10.3 #33

Merged
merged 4 commits into from
Oct 12, 2024
Merged

MEDIUM CODE RUB: Upgrade to The Standard 2.10.3 #33

merged 4 commits into from
Oct 12, 2024

Conversation

LBoullosa
Copy link
Member

closes #32

@LBoullosa LBoullosa marked this pull request as ready for review October 12, 2024 15:13
@LBoullosa LBoullosa requested review from cjdutoit and glhays October 12, 2024 15:14
glhays
glhays reviewed Oct 12, 2024
View reviewed changes
...vices/Foundations/DependenciesInjections/DependencyInjectionServiceTests.Logic.GetService.cs Outdated Show resolved Hide resolved
...dations/DependenciesInjections/DependencyInjectionServiceTests.Logic.BuildServiceProvider.cs Outdated Show resolved Hide resolved
...pendenciesInjections/DependencyInjectionServiceTests.Exceptions.RegisterServiceDescriptor.cs Outdated Show resolved Hide resolved
...pendenciesInjections/DependencyInjectionServiceTests.Exceptions.RegisterServiceDescriptor.cs Outdated Show resolved Hide resolved
...e.Tests.Unit/Services/Foundations/Assemblies/AssemblyServiceTests.Validations.GetAssembly.cs Outdated Show resolved Hide resolved
.../Services/Foundations/Assemblies/AssemblyServiceTests.Logic.GetApplicationPathsAssemblies.cs Outdated Show resolved Hide resolved
...re.Tests.Unit/Services/Foundations/Assemblies/AssemblyServiceTests.Exceptions.GetAssembly.cs Outdated Show resolved Hide resolved
...re.Tests.Unit/Services/Foundations/Assemblies/AssemblyServiceTests.Exceptions.GetAssembly.cs Outdated Show resolved Hide resolved
...re.Tests.Unit/Services/Foundations/Assemblies/AssemblyServiceTests.Exceptions.GetAssembly.cs Outdated Show resolved Hide resolved
STX.SPAL.Core.Tests.Unit/STX.SPAL.Core.Tests.Unit.csproj Outdated Show resolved Hide resolved
@glhays
Copy link
Member

glhays commented Oct 12, 2024

@LBoullosa is it your opinion that we do not need to ValueTask the two service exception partial classes? meaning the...

throw CreateAssemblyValidationException(
                    invalidAssemblyPathException);

=>

throw await CreateAssemblyValidationExceptionAsync(invalidAssemblyPathException);

then ValueTask this method as well.

@LBoullosa
Copy link
Member Author

@LBoullosa is it your opinion that we do not need to ValueTask the two service exception partial classes? meaning the...

throw CreateAssemblyValidationException(
                    invalidAssemblyPathException);

=>

throw await CreateAssemblyValidationExceptionAsync(invalidAssemblyPathException);

then ValueTask this method as well.

I don´t see it is neccesary. It´s like the inner validations methods which was reverted from using async in the last session.

@glhays glhays merged commit 5b19c65 into main Oct 12, 2024
4 checks passed
@glhays glhays deleted the users/lboullosa/coderub-upgrade-standard-2.10.3 branch October 12, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glhays glhays glhays approved these changes

@cjdutoit cjdutoit Awaiting requested review from cjdutoit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MEDIUM CODERUB: Upgrade to 2.10.3
2 participants
@LBoullosa @glhays