Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUNDATIONS: ServiceCollectionService #19

Merged
merged 25 commits into from
Jun 7, 2024

Conversation

LBoullosa
Copy link
Member

closes #10

@LBoullosa LBoullosa changed the title ShouldRegisterServiceDescriptor -> FAIL FOUNDATIONS: ServiceCollectionService Jun 3, 2024
@cjdutoit cjdutoit added the FOUNDATIONS The foundations category label Jun 3, 2024
@LBoullosa LBoullosa self-assigned this Jun 5, 2024
@LBoullosa LBoullosa marked this pull request as ready for review June 5, 2024 17:50
glhays
glhays previously approved these changes Jun 5, 2024
Copy link
Member

@glhays glhays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

glhays
glhays previously approved these changes Jun 6, 2024
@LBoullosa LBoullosa requested review from cjdutoit and glhays June 7, 2024 08:15
@cjdutoit cjdutoit merged commit 8a32629 into main Jun 7, 2024
4 checks passed
@cjdutoit cjdutoit deleted the users/lboullosa/foundations-service-collection branch June 7, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FOUNDATIONS The foundations category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FOUNDATIONS: ServiceCollectionService
3 participants