-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gh 2 adding news page #29
base: master
Are you sure you want to change the base?
Gh 2 adding news page #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LAKSHMANANR25 kindly provide details of changes you've made, screenshots of any UI changes etc. Always provide description in the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, always try to use an external css and js script file, helps to keep the HTML file clean just like done in #16 . You can take reference from this repository like how we have kept all css, js files etc into separate directories.
Also always mention what issue you are fixing/mentioning like Fix: #<issue-id>
so that it can be traced back to the relevant issue. 🙂 @LAKSHMANANR25
Fix : #4 the ui does not have major changes, i have changed the content from the automated Lorem ipsum, i have then created separate files for css and js, |
nice work! @LAKSHMANANR25 |
Fix: #4 i have added UI to news.html using some of the parts from other html files and used some mouseover functions, the last image is also by mouseover