Enabling Surefire to run test classes and test methods in any order specified #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odRunOrder on command line) to choose order of methods. possible values include: unsorted (default, however junit would do it otherwise), alphabetical, reverse_alphabetical and random. New custom orders can be implemented in DefaultRunOrderCalculator class. Supports Junit4 and JUnit47 providers.
…run fixed order, tests to run can be passed in as a list from a file.
winglam
changed the title
| @@ -106,6 +264,52 @@ else if ( sortOrder != null ) | |||
| } | |||
| } | |||
|
|
|||
| private String parseFlakyTestOrder( String s ) | |||
| { | |||
| if ( s != null && s != "" ) | |||
There was a problem hiding this comment.
I detect that this code is problematic. According to the Bad practice (BAD_PRACTICE), ES: Comparison of String objects using == or != (ES_COMPARING_STRINGS_WITH_EQ).
This code compares java.lang.String objects for reference equality using the == or != operators. Unless both strings are either constants in a source file, or have been interned using the String.intern() method, the same string value may be represented by two different String objects. Consider using the equals(Object) method instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.