Merge branch 'main' into topic/add-gettempfilename

Testably · Apr 20, 2024 · a3c8fab · a3c8fab
2 parents 4aecdaf + 066fb69
commit a3c8fab
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 2 deletions.
diff --git a/Source/Testably.Abstractions.Testing/Helpers/Execute.SimulatedPath.cs b/Source/Testably.Abstractions.Testing/Helpers/Execute.SimulatedPath.cs
@@ -318,7 +318,15 @@ public bool HasExtension(ReadOnlySpan<char> path)
 
 		/// <inheritdoc cref="IPath.HasExtension(string)" />
 		public bool HasExtension([NotNullWhen(true)] string? path)
-			=> System.IO.Path.HasExtension(path);
+		{
+			if (path == null)
+			{
+				return false;
+			}
+
+			return TryGetExtensionIndex(path, out var dotIndex)
+			       && dotIndex < path.Length - 1;
+		}
 
 #if FEATURE_SPAN
 		/// <inheritdoc cref="IPath.IsPathFullyQualified(ReadOnlySpan{char})" />
@@ -405,7 +413,11 @@ public ReadOnlySpan<char> TrimEndingDirectorySeparator(ReadOnlySpan<char> path)
 #if FEATURE_PATH_ADVANCED
 		/// <inheritdoc cref="IPath.TrimEndingDirectorySeparator(string)" />
 		public string TrimEndingDirectorySeparator(string path)
-			=> System.IO.Path.TrimEndingDirectorySeparator(path);
+		{
+			return EndsInDirectorySeparator(path) && path.Length != GetRootLength(path)
+				? path.Substring(0, path.Length - 1)
+				: path;
+		}
 #endif
 
 #if FEATURE_PATH_JOIN

diff --git a/...s/Testably.Abstractions.Tests.SourceGenerator/ClassGenerators/FileSystemClassGenerator.cs b/...s/Testably.Abstractions.Tests.SourceGenerator/ClassGenerators/FileSystemClassGenerator.cs
@@ -274,9 +274,11 @@ private bool IncludeSimulatedTests(ClassModel @class)
 			"GetRandomFileNameTests",
 			"GetTempFileNameTests",
 			"GetTempPathTests",
+			"HasExtensionTests",
 			"IsPathRootedTests",
 			"JoinTests",
 			"Tests",
+			"TrimEndingDirectorySeparatorTests",
 			"TryJoinTests"
 		];
 		return @class.Namespace

diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/Path/HasExtensionTests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/Path/HasExtensionTests.cs
@@ -14,6 +14,7 @@ public void HasExtension_Null_ShouldReturnFalse()
 	}
 
 	[SkippableTheory]
+	[InlineAutoData("abc.", false)]
 	[InlineAutoData(".foo", true)]
 	[InlineAutoData(".abc.xyz", true)]
 	[InlineAutoData("foo", false)]
@@ -30,6 +31,7 @@ public void HasExtension_ShouldReturnExpectedResult(
 
 #if FEATURE_SPAN
 	[SkippableTheory]
+	[InlineAutoData("abc.", false)]
 	[InlineAutoData(".foo", true)]
 	[InlineAutoData(".abc.xyz", true)]
 	[InlineAutoData("foo", false)]