-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: extract ACL related functionality #913
refactor: extract ACL related functionality #913
Conversation
@fgreinacher : |
Co-authored-by: Peter Baumann <[email protected]>
Co-authored-by: Peter Baumann <[email protected]>
I'll have a deeper look at this by the middle of the week. @siprbaum Do you want to do another pass? |
src/System.IO.Abstractions.TestingHelpers/FileSystemExtensibility.cs
Outdated
Show resolved
Hide resolved
src/TestableIO.System.IO.Abstractions.Wrappers/DirectoryAclExtensions.cs
Outdated
Show resolved
Hide resolved
src/TestableIO.System.IO.Abstractions.Wrappers/FileAclExtensions.cs
Outdated
Show resolved
Hide resolved
- Replace IFileSystemExtensibility with IFileSystemAclSupport
src/System.IO.Abstractions.TestingHelpers/FileSystemExtensibility.cs
Outdated
Show resolved
Hide resolved
@fgreinacher : |
@vbreuss I'd like to push out a clean v18 first. We can then just bump major again for this change, no problem :) |
@fgreinacher: I merged the latest changes from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your rework @vbreuss - I like it a lot know.
I have a few small suggestions/questions and then we're good to go 🚀
src/System.IO.Abstractions.TestingHelpers/FileSystemExtensibility.cs
Outdated
Show resolved
Hide resolved
src/TestableIO.System.IO.Abstractions.TestingHelpers/MockFileData.cs
Outdated
Show resolved
Hide resolved
It will break people that are currently mocking the methods on the interface level, so I'd rather bump major to not surprise folks :) Could you bump |
@fgreinacher : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @vbreuss 🎉
This is addressed in release v19.0.1. |
This is addressed in release v19.0.1. |
Remove the ACL-Features from the interfaces and instead implement them as extension methods implemented in "TestableIO.System.IO.Abstractions.Wrappers".
This removes the dependency on
System.IO.FileSystem.AccessControl
from the interface project.This is part of the approach discussed in #883
BREAKING CHANGE: This refactoring removes ACL-related methods from the interface project and replaces them with extension methods in
TestableIO.System.IO.Abstractions.Wrappers
.