fix: prefix bug in MockDirectory.EnumerateDirectories (#815) #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`System.IO.Directory.EnumerateDirectories(path)` guarantees that returned paths are always prefixed with the value provided in the `path` parameter. However, `MockDirectory.EnumerateDirectories` always returned absolute paths, leading to an inconsistent behavior (e.g. when using relative paths). We now check returned paths from `MockDirectory.EnumerateDirectories` and provide the proper prefix path.
vbreuss
requested changes
Oct 20, 2023
tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockDirectoryTests.cs
Outdated
Show resolved
Hide resolved
tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockDirectoryTests.cs
Outdated
Show resolved
Hide resolved
vbreuss
requested changes
Oct 24, 2023
src/TestableIO.System.IO.Abstractions.TestingHelpers/MockDirectory.cs
Outdated
Show resolved
Hide resolved
vbreuss
added a commit
to Testably/Testably.Abstractions
that referenced
this pull request
Oct 24, 2023
…415) Reproduce the finding from TestableIO/System.IO.Abstractions#1046
vbreuss
approved these changes
Oct 30, 2023
|
Thanks for the fix @Phoenox, please have a look at the failing ubuntu and macOS tests 🙇 |
fgreinacher
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Sorry @Phoenox, this slipped through my notifications. Looks great, thanks a ton for the fix!
mergify bot
referenced
this pull request
in Testably/Testably.Abstractions
Dec 5, 2023
…20 (#432) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [TestableIO.System.IO.Abstractions](https://togithub.com/TestableIO/System.IO.Abstractions) | `19.2.87` -> `20.0.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>TestableIO/System.IO.Abstractions (TestableIO.System.IO.Abstractions)</summary> ### [`v19.2.91`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v19.2.91) ##### What's Changed - chore(deps): update dependency saucecontrol.inheritdoc to v1.4.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/1057](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1057) - chore(deps): update dependency moq to v4.20.70 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/1059](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1059) - chore(deps): update actions/setup-dotnet action to v4 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/1061](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1061) - fix: prefix bug in MockDirectory.EnumerateDirectories ([#​815](https://togithub.com/TestableIO/System.IO.Abstractions/issues/815)) by [@​Phoenox](https://togithub.com/Phoenox) in [https://github.com/TestableIO/System.IO.Abstractions/pull/1046](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1046) ##### New Contributors - [@​Phoenox](https://togithub.com/Phoenox) made their first contribution in [https://github.com/TestableIO/System.IO.Abstractions/pull/1046](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1046) **Full Changelog**: TestableIO/System.IO.Abstractions@v19.2.87...v19.2.91 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Testably/Testably.Abstractions). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44MS4zIiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #815
System.IO.Directory.EnumerateDirectories(path)guarantees that returned paths are always prefixed with the value provided in thepathparameter. However,MockDirectory.EnumerateDirectoriesalways returned absolute paths, leading to an inconsistent behavior (e.g. when using relative paths).We now check returned paths from
MockDirectory.EnumerateDirectoriesand provide the proper prefix path.