Add .NET Core support - WIP #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will be awesome to see this in! Ping me on twitter if you get stuck |
|
Great, will do. |
|
Run into a bit of a blocker in this class that has a dependency on |
|
FYI This fixes #77 |
|
Picked this one up again 👍 |
|
Hello! I'm curious to know how it's going with the .NET Core support? I'm interested in contributing to Shouldly and would like to see TestStack.ConventionTests upgraded to .NET Core so I can use it with Shouldly. Is there anything I can do to help? |
mwhelan
added a commit
that referenced
this pull request
Mar 28, 2020
feat (NetCoreSupport): Continue work done on PR #78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial attempted at adding .NET Standard support - still work in progress.
Shouldly's tests have a dependency on this so as soon as TestStack.ConventionTests supports .NET Standard then people will be able to build/contribute to Shouldly across multiple operating systems so it's a win-win.
This is the first time I've done this so if there are any suggestions then please feel free to fire them my way.