Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cmake_minimum_required version to 3.5 #77

Merged
merged 1 commit into from
May 6, 2024

Conversation

jlblancoc
Copy link
Contributor

With recent versions of cmake (>? 3.28), one gets this warning for cmake required version <3.5:

CMake Deprecation Warning at 3rdparty/robin-map/CMakeLists.txt:1 (cmake_minimum_required):
Compatibility with CMake < 3.5 will be removed from a future version of
CMake.

The oldest active Ubuntu distro (20.04) already shipped cmake 3.16.3, so I hope there is no issue in upgrading this required version to the minimum that cleans up the warning.

@Tessil Tessil merged commit 1115dad into Tessil:master May 6, 2024
9 of 11 checks passed
@Tessil
Copy link
Owner

Tessil commented May 6, 2024

Thanks, it looks reasonable to increase it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants