Skip to content

Commit

Permalink
include name prefix on nlb ip addresses
Browse files Browse the repository at this point in the history
  • Loading branch information
jlauritsen committed Jan 11, 2024
1 parent f5fbec9 commit 9d4f262
Show file tree
Hide file tree
Showing 4 changed files with 29 additions and 29 deletions.
18 changes: 9 additions & 9 deletions deployments/azure/all-in-one.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"_generator": {
"name": "bicep",
"version": "0.24.24.22086",
"templateHash": "8475022372092204787"
"templateHash": "15418479916005263131"
}
},
"parameters": {
Expand Down Expand Up @@ -651,7 +651,7 @@
"_generator": {
"name": "bicep",
"version": "0.24.24.22086",
"templateHash": "296837087008094674"
"templateHash": "3385554541683646128"
}
},
"parameters": {
Expand Down Expand Up @@ -682,7 +682,7 @@
{
"type": "Microsoft.Network/publicIPAddresses",
"apiVersion": "2021-08-01",
"name": "inbound",
"name": "[format('{0}-inbound', parameters('name'))]",
"location": "[parameters('location')]",
"sku": {
"name": "Standard"
Expand All @@ -696,7 +696,7 @@
{
"type": "Microsoft.Network/publicIPAddresses",
"apiVersion": "2021-08-01",
"name": "outbound",
"name": "[format('{0}-outbound', parameters('name'))]",
"location": "[parameters('location')]",
"sku": {
"name": "Standard"
Expand All @@ -721,15 +721,15 @@
"name": "[format('{0}Inbound', parameters('name'))]",
"properties": {
"publicIPAddress": {
"id": "[resourceId('Microsoft.Network/publicIPAddresses', 'inbound')]"
"id": "[resourceId('Microsoft.Network/publicIPAddresses', format('{0}-inbound', parameters('name')))]"
}
}
},
{
"name": "[format('{0}Outbound', parameters('name'))]",
"properties": {
"publicIPAddress": {
"id": "[resourceId('Microsoft.Network/publicIPAddresses', 'outbound')]"
"id": "[resourceId('Microsoft.Network/publicIPAddresses', format('{0}-outbound', parameters('name')))]"
}
}
}
Expand Down Expand Up @@ -766,8 +766,8 @@
},
"tags": "[parameters('tags')]",
"dependsOn": [
"[resourceId('Microsoft.Network/publicIPAddresses', 'inbound')]",
"[resourceId('Microsoft.Network/publicIPAddresses', 'outbound')]"
"[resourceId('Microsoft.Network/publicIPAddresses', format('{0}-inbound', parameters('name')))]",
"[resourceId('Microsoft.Network/publicIPAddresses', format('{0}-outbound', parameters('name')))]"
]
}
],
Expand All @@ -781,7 +781,7 @@
},
"PublicIp": {
"type": "string",
"value": "[reference(resourceId('Microsoft.Network/publicIPAddresses', 'inbound'), '2021-08-01').ipAddress]"
"value": "[reference(resourceId('Microsoft.Network/publicIPAddresses', format('{0}-inbound', parameters('name'))), '2021-08-01').ipAddress]"
}
}
}
Expand Down
18 changes: 9 additions & 9 deletions deployments/azure/jupyter.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"_generator": {
"name": "bicep",
"version": "0.24.24.22086",
"templateHash": "7118450702390745805"
"templateHash": "18234375492270445054"
}
},
"parameters": {
Expand Down Expand Up @@ -475,7 +475,7 @@
"_generator": {
"name": "bicep",
"version": "0.24.24.22086",
"templateHash": "296837087008094674"
"templateHash": "3385554541683646128"
}
},
"parameters": {
Expand Down Expand Up @@ -506,7 +506,7 @@
{
"type": "Microsoft.Network/publicIPAddresses",
"apiVersion": "2021-08-01",
"name": "inbound",
"name": "[format('{0}-inbound', parameters('name'))]",
"location": "[parameters('location')]",
"sku": {
"name": "Standard"
Expand All @@ -520,7 +520,7 @@
{
"type": "Microsoft.Network/publicIPAddresses",
"apiVersion": "2021-08-01",
"name": "outbound",
"name": "[format('{0}-outbound', parameters('name'))]",
"location": "[parameters('location')]",
"sku": {
"name": "Standard"
Expand All @@ -545,15 +545,15 @@
"name": "[format('{0}Inbound', parameters('name'))]",
"properties": {
"publicIPAddress": {
"id": "[resourceId('Microsoft.Network/publicIPAddresses', 'inbound')]"
"id": "[resourceId('Microsoft.Network/publicIPAddresses', format('{0}-inbound', parameters('name')))]"
}
}
},
{
"name": "[format('{0}Outbound', parameters('name'))]",
"properties": {
"publicIPAddress": {
"id": "[resourceId('Microsoft.Network/publicIPAddresses', 'outbound')]"
"id": "[resourceId('Microsoft.Network/publicIPAddresses', format('{0}-outbound', parameters('name')))]"
}
}
}
Expand Down Expand Up @@ -590,8 +590,8 @@
},
"tags": "[parameters('tags')]",
"dependsOn": [
"[resourceId('Microsoft.Network/publicIPAddresses', 'inbound')]",
"[resourceId('Microsoft.Network/publicIPAddresses', 'outbound')]"
"[resourceId('Microsoft.Network/publicIPAddresses', format('{0}-inbound', parameters('name')))]",
"[resourceId('Microsoft.Network/publicIPAddresses', format('{0}-outbound', parameters('name')))]"
]
}
],
Expand All @@ -605,7 +605,7 @@
},
"PublicIp": {
"type": "string",
"value": "[reference(resourceId('Microsoft.Network/publicIPAddresses', 'inbound'), '2021-08-01').ipAddress]"
"value": "[reference(resourceId('Microsoft.Network/publicIPAddresses', format('{0}-inbound', parameters('name'))), '2021-08-01').ipAddress]"
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions deployments/azure/modules/nlb.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ param jupyterHttpPort int = 0
param tags object = {}

resource lbPublicIPAddress 'Microsoft.Network/publicIPAddresses@2021-08-01' = {
name: 'inbound'
name: '${name}-inbound'
location: location
sku: {
name: 'Standard'
Expand All @@ -19,7 +19,7 @@ resource lbPublicIPAddress 'Microsoft.Network/publicIPAddresses@2021-08-01' = {
}

resource lbPublicIPAddressOutbound 'Microsoft.Network/publicIPAddresses@2021-08-01' = {
name: 'outbound'
name: '${name}-outbound'
location: location
sku: {
name: 'Standard'
Expand Down
18 changes: 9 additions & 9 deletions deployments/azure/workspaces.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"_generator": {
"name": "bicep",
"version": "0.24.24.22086",
"templateHash": "11148566380890649802"
"templateHash": "14046707337037786478"
}
},
"parameters": {
Expand Down Expand Up @@ -622,7 +622,7 @@
"_generator": {
"name": "bicep",
"version": "0.24.24.22086",
"templateHash": "296837087008094674"
"templateHash": "3385554541683646128"
}
},
"parameters": {
Expand Down Expand Up @@ -653,7 +653,7 @@
{
"type": "Microsoft.Network/publicIPAddresses",
"apiVersion": "2021-08-01",
"name": "inbound",
"name": "[format('{0}-inbound', parameters('name'))]",
"location": "[parameters('location')]",
"sku": {
"name": "Standard"
Expand All @@ -667,7 +667,7 @@
{
"type": "Microsoft.Network/publicIPAddresses",
"apiVersion": "2021-08-01",
"name": "outbound",
"name": "[format('{0}-outbound', parameters('name'))]",
"location": "[parameters('location')]",
"sku": {
"name": "Standard"
Expand All @@ -692,15 +692,15 @@
"name": "[format('{0}Inbound', parameters('name'))]",
"properties": {
"publicIPAddress": {
"id": "[resourceId('Microsoft.Network/publicIPAddresses', 'inbound')]"
"id": "[resourceId('Microsoft.Network/publicIPAddresses', format('{0}-inbound', parameters('name')))]"
}
}
},
{
"name": "[format('{0}Outbound', parameters('name'))]",
"properties": {
"publicIPAddress": {
"id": "[resourceId('Microsoft.Network/publicIPAddresses', 'outbound')]"
"id": "[resourceId('Microsoft.Network/publicIPAddresses', format('{0}-outbound', parameters('name')))]"
}
}
}
Expand Down Expand Up @@ -737,8 +737,8 @@
},
"tags": "[parameters('tags')]",
"dependsOn": [
"[resourceId('Microsoft.Network/publicIPAddresses', 'inbound')]",
"[resourceId('Microsoft.Network/publicIPAddresses', 'outbound')]"
"[resourceId('Microsoft.Network/publicIPAddresses', format('{0}-inbound', parameters('name')))]",
"[resourceId('Microsoft.Network/publicIPAddresses', format('{0}-outbound', parameters('name')))]"
]
}
],
Expand All @@ -752,7 +752,7 @@
},
"PublicIp": {
"type": "string",
"value": "[reference(resourceId('Microsoft.Network/publicIPAddresses', 'inbound'), '2021-08-01').ipAddress]"
"value": "[reference(resourceId('Microsoft.Network/publicIPAddresses', format('{0}-inbound', parameters('name'))), '2021-08-01').ipAddress]"
}
}
}
Expand Down

0 comments on commit 9d4f262

Please sign in to comment.