Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tree): custom icons cannot be clicked without child nodes #4638

Merged
merged 2 commits into from
Oct 11, 2024
Merged

fix(tree): custom icons cannot be clicked without child nodes #4638

merged 2 commits into from
Oct 11, 2024

Conversation

RSS1102
Copy link
Contributor

@RSS1102 RSS1102 commented Oct 10, 2024

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

close #4571

💡 需求背景和解决方案

📝 更新日志

  • fix(tree): custom icons cannot be clicked without child nodes

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@RSS1102

This comment was marked as resolved.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024 •
edited
Loading

完成

@RSS1102
Copy link
Contributor Author

RSS1102 commented Oct 10, 2024

目前是检测对应节点上的class是否包含t-tree__item--open。
尝试使用过getComputedStyle获取color但是没有成功。

@RSS1102 RSS1102 marked this pull request as ready for review October 10, 2024 19:40
@uyarn uyarn merged commit ad5a482 into Tencent:develop Oct 11, 2024
7 checks passed
@RSS1102 RSS1102 deleted the fix/tree/last-icon-cant-selected branch October 11, 2024 13:27
@github-actions github-actions bot mentioned this pull request Oct 26, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uyarn uyarn uyarn approved these changes

@PengYYYYY PengYYYYY Awaiting requested review from PengYYYYY PengYYYYY is a code owner

@chaishi chaishi Awaiting requested review from chaishi chaishi is a code owner

@xiaosansiji xiaosansiji Awaiting requested review from xiaosansiji xiaosansiji is a code owner

@honkinglin honkinglin Awaiting requested review from honkinglin honkinglin is a code owner

@LeeJim LeeJim Awaiting requested review from LeeJim LeeJim is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tree] 自定义的图标不应被可点击
2 participants
@RSS1102 @uyarn