wip: 重构 Picker 组件 对齐 mobile-vue #514
Open
+715
−252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
HaixingOoO
reviewed
Sep 9, 2024
| @@ -1,68 +1,133 @@ | |||
| import React, { FC, useMemo } from 'react'; | |||
| import React, { FC, useState, MouseEvent, useEffect } from 'react'; | |||
HaixingOoO
reviewed
Sep 9, 2024
| @@ -1,68 +1,133 @@ | |||
| import React, { FC, useMemo } from 'react'; | |||
| import React, { FC, useState, MouseEvent, useEffect } from 'react'; | |||
| import useDefaultProps from 'tdesign-mobile-react/hooks/useDefaultProps'; | |||
There was a problem hiding this comment.
这里的tdesign-mobile-react引入是不是错了？
HaixingOoO
reviewed
Sep 9, 2024
| import useConfig from '../_util/useConfig'; | ||
| import useDefault from '../_util/useDefault'; | ||
| import withNativeProps, { NativeProps } from '../_util/withNativeProps'; | ||
| import PickerView, { getPickerViewDefaultValue } from './PickerView'; | ||
| import { NativeProps } from '../_util/withNativeProps'; |
There was a problem hiding this comment.
在common.ts里引入classname和style的 type
HaixingOoO
reviewed
Sep 9, 2024
| import Button from '../button'; | ||
| import Popup from '../popup'; | ||
| import { TdPickerProps, PickerColumnItem, PickerValue } from './type'; | ||
| import { PickerColumn } from '.'; |
HaixingOoO
reviewed
Sep 9, 2024
| import { TdPickerProps, PickerColumnItem, PickerValue } from './type'; | ||
| import { PickerColumn } from '.'; | ||
|
|
||
| import PickerItem, { type PickerItemExposeRef } from './PickerItem'; |
HaixingOoO
reviewed
Sep 9, 2024
Comment on lines
+16
to
+20
| function getDefaultText(prop: unknown, defaultText: string): string { | ||
| if (isString(prop)) return prop; | ||
| if (isBoolean(prop)) return defaultText; | ||
| return; | ||
| } |
HaixingOoO
reviewed
Sep 9, 2024
Comment on lines
33
to
34
| const { classPrefix } = useConfig(); | ||
| const name = `${classPrefix}-picker`; |
HaixingOoO
reviewed
Sep 9, 2024
Comment on lines
+37
to
+38
| const confirmButtonText = getDefaultText(props.confirmBtn, undefined); | ||
| const cancelButtonText = getDefaultText(props.cancelBtn, undefined); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
📝 更新日志
fix(组件名称): 处理问题或特性描述 ...
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单